Code review comment for ~kzapalowicz/snappy-hwe-snaps/+git/jenkins-jobs:feature/make-test-snap-in-sync

Please see comments below, especially the one about yaml format.

Also, I do not think this should be a separate job. In build-scripts there was a function, set_test_type(), which checked if there were tests defined for real hardware, and in the test job this was checked and real HW tests where run if appropriate. We should do something similar so this gets run by the snap-test.sh job if appropriate. I would also keep the original structure as a function called run_hardware_tests().

Finally, this should be tested using the alsa-utils snap, preferably before merging if possible (we can merge and check after if there is no easy way).