Merge ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:fix/pulseaudio-wrong-command into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Simon Fels
Approved revision: fe7e5546a6d31835edbcc7e20776473ee79f8d97
Merged at revision: 8d1f2d3bf85fe123bb208c1dd9f83bfdd110cf80
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:fix/pulseaudio-wrong-command
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 35 lines (+7/-4)
1 file modified
pulseaudio/units/pulseaudio.pxu (+7/-4)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Needs Fixing
Simon Fels Approve
Review via email: mp+313342@code.launchpad.net

Commit message

pulseaudio: fix tests to match the snap current usage

This commit adds the missing "pulseaudio." prefix to the commands used
for testing.

Also it extends the verification critera for a music playback test to
cover for a situation where the speakers are not available.

Description of the change

pulseaudio: fix tests to match the snap current usage

This commit adds the missing "pulseaudio." prefix to the commands used
for testing.

Also it extends the verification critera for a music playback test to
cover for a situation where the speakers are not available.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
Simon Fels (morphis) wrote :

LGTM, home plug was added for parec.

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/pulseaudio/units/pulseaudio.pxu b/pulseaudio/units/pulseaudio.pxu
index 3b304e7..453232a 100644
--- a/pulseaudio/units/pulseaudio.pxu
+++ b/pulseaudio/units/pulseaudio.pxu
@@ -29,7 +29,7 @@ depends: pulseaudio/setup/ensure_interface_connection_setup
29_steps:29_steps:
30 1. List the loaded modules30 1. List the loaded modules
31 .31 .
32 $ pactl list short32 $ sudo pulseaudio.pactl list short
33 .33 .
34_verification:34_verification:
35 Verify that you see output similar to following:35 Verify that you see output similar to following:
@@ -59,7 +59,7 @@ depends: pulseaudio/setup/ensure_interface_connection_setup
59_steps:59_steps:
60 1. Record an audio .wav file60 1. Record an audio .wav file
61 .61 .
62 $ parecord ~/record.wav62 $ sudo pulseaudio.parec ~/record.wav
63 .63 .
64_verification:64_verification:
65 Verify that the record.wav file has been created and it's size is65 Verify that the record.wav file has been created and it's size is
@@ -74,7 +74,10 @@ depends: pulseaudio/setup/ensure_interface_connection_setup
74_steps:74_steps:
75 1. Play an audio .wav file75 1. Play an audio .wav file
76 .76 .
77 $ paplay ~/file.wav77 $ sudo pulseaudio.paplay ~/file.wav
78 .78 .
79_verification:79_verification:
80 Verify that the audio is hearable through the speakers.80 Verify that the audio is hearable through the speakers. In case the
81 speakers are not available verify that the sink status has changed
82 from SUSPEND to RUNNING [use the sudo pulseaudio.pactl list sinks
83 command for that]

Subscribers

People subscribed via source and target branches