Merge ~kzapalowicz/snappy-hwe-snaps/+git/engineering-tests:feature/plainbox-wireless-tools into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

[Konrad Zapałowicz]

Add plainbox tests for wireless-tools.rfkill

This commit adds plainbox tests for wireless-tools snap with focus
on testing the rfkill command from wireless-tools package. There
are four tests defined:
  - Make sure that it is possible to connect plugs and slots
  - Check if rfkill switches are listed
  - Check if it is possible to change state of the rfkill switch
  - Check if it is possible to receive event updates on the state of
    rfkill switches.

Add plainbox tests for wireless-tools focusing on rfkill

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:e55a993a96a80fbfecf695dbb4b224803048a886
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/273/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/175/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/273/rebuild

review: Needs Fixing (continuous-integration)

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:e55a993a96a80fbfecf695dbb4b224803048a886
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/274/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/176/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/274/rebuild

review: Needs Fixing (continuous-integration)

[Simon Fels (morphis)]

LGTM

review: Approve

[Matteo Croce (teknoraver)]

review: Approve

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:b639ba130f94f35ebcd03f68ee1f9f660f958c23
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/276/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/178/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/276/rebuild

review: Needs Fixing (continuous-integration)

[Jim Hodapp (jhodapp)]

Please make sure to update the README.md file to mention your wireless-tools-tests.

Just a couple of minor comments inline below.

review: Needs Fixing

[Jim Hodapp (jhodapp)]

review: Needs Fixing

[Jim Hodapp (jhodapp)]

LGTM.

review: Approve

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:de0ee3a3d22a3e635889639826676a0cd572c59a
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/278/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/180/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/278/rebuild

review: Needs Fixing (continuous-integration)

diff --git a/bin/run-wireless-tools-tests b/bin/run-wireless-tools-tests
new file mode 100755
index 0000000..29cd139
--- /dev/null
+++ b/bin/run-wireless-tools-tests
@@ -0,0 +1,5 @@
+#!/bin/sh
+export PATH="$PATH:$SNAP/usr/sbin"
+exec python3 $(which plainbox) \
+	run -i '2016.com.canonical.system-enablement::wireless-tools.*' \
+	"$@"
diff --git a/snapcraft.yaml b/snapcraft.yaml
index a10b07a..079d6ec 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -25,6 +25,8 @@ apps:
     command: bin/run-tpm1.2-tests
   wifi-ap:
     command: bin/run-wifi-ap-tests
+  wireless-tools:
+    command: bin/run-wireless-tools-tests
 
 parts:
   common:
diff --git a/tests/units/wireless-tools.pxu b/tests/units/wireless-tools.pxu
new file mode 100644
index 0000000..3c59f13
--- /dev/null
+++ b/tests/units/wireless-tools.pxu
@@ -0,0 +1,102 @@
+# Copyright 2016 Canonical Ltd.
+# All rights reserved.
+#
+# Written by:
+#   Konrad Zapalowicz <[e-mail]>
+
+unit: category
+id:wireless-tools
+_name: Wireless Tools
+
+id: wireless-tools/setup/ensure_interface_connection_setup
+category_id: wireless-tools
+_description: Ensure that wireless_tools interfaces are connected
+plugin: manual
+_steps:
+  1. Connect required wireless-tools slots/plugs 
+  .
+    $ sudo snap connect wireless-tools:network-control :network-control
+  .
+_verification:
+  Verify that you see the following when running snap interfaces:
+    :network                wireless-tools
+    :network-bind           wireless-tools
+    :network-control        wireless-tools
+
+id: wireless-tools/rfkill/list
+category_id:wireless-tools
+plugin: manual
+depends: wireless-tools/setup/ensure_interface_connection_setup
+_summary: The RF kill switches are listed
+_purpose: Check if all RF kill switches that are available on the HW are listed.
+_steps:
+  1. Execute the following command to retrieve the list of all RF kill switches:
+  .
+    $ /snap/bin/wireless-tools.rfkill list
+  .
+_verification:
+  Your expected RF kill switche(s) is/are shown in the output such as:
+    <id>: <name>: <description>
+        Soft blocked: <yes|no>
+        Hard blocked: <yes|no>
+
+  For example:
+    1: phy0: Wireless LAN
+        Soft blocked: no
+        Hard blocked: no
+    2: hci0: Bluetooth
+        Soft blocked: yes
+        Hard blocked: no
+
+id: wireless-tools/rfkill/change_state
+category_id:wireless-tools
+plugin: manual
+depends: wireless-tools/rfkill/list
+_summary: It is possible to change the state of RF kill
+_purpose: Check if it is possible to change a state of the RF kill switch
+_steps:
+  1. Execute the following commands first to list the available RF kill switches
+  .
+    $ /snap/bin/wireles-tools.rfkill list
+  .
+  2. Change the state of the selected RF kill switch using the id obtained in
+     the previous step. Note that the action: block or unblock shall be selected
+     based on the initial state of the RF kill switch: blocked yes or no.
+  .
+    $ /snap/bin/wireless-tools.rfkill [un]block <id>
+  .
+_verification:
+  There shall be no output on the standard output however there shall be a
+  change of state visible when listing the RF kill switches.
+  .
+    $ /snap/bin/wireless_tools.rfkill list
+  .
+  
+id: wireless_tools/rfkill/capture_event
+category_id: wireless-tools
+plugin: manual
+depends: wireless-tools/rfkill/list
+_summary: It is possible to see the events related to RF kill switch(es)
+_purpose: Check if it is possible to capture the event notifications
+_steps:
+  1. Execute the following command to enter the capture-events mode
+  .
+    $ /snap/bin/wireless_tools.rfkill event
+  .
+  2. Change the state of the RF kill switch using a hardware button if
+     available.
+_verification:
+  The command executed in the step 1 shall block and display the current state
+  of the RF kill switches in a following form:
+    <timestamp>: idx <id> type <type id> op <op id> soft <0|1> hard <0|1>
+  Pressing the hardware RF kill switch should be printed in the following
+  form as in the above. For example:
+    1478774281.491635: idx 0 type 2 op 0 soft 0 hard 0
+    1478774281.491762: idx 1 type 1 op 0 soft 0 hard 0
+    1478774281.491776: idx 2 type 2 op 0 soft 1 hard 0
+    1478774301.905695: idx 2 type 2 op 2 soft 0 hard 0
+    1478774307.837112: idx 0 type 2 op 2 soft 1 hard 0
+    1478774310.817935: idx 2 type 2 op 2 soft 1 hard 0
+    1478774310.818989: idx 2 type 2 op 1 soft 1 hard 0
+
+