Merge ~kwmonroe/layer-leadership:master into layer-leadership:master

Proposed by Kevin W Monroe
Status: Merged
Merged at revision: 8846afcc42efe8a6ddd09c3122f2b0b43efdf3cc
Proposed branch: ~kwmonroe/layer-leadership:master
Merge into: layer-leadership:master
Diff against target: 48 lines (+0/-18)
1 file modified
dev/null (+0/-18)
Reviewer Review Type Date Requested Status
Stuart Bishop Approve
Review via email: mp+299986@code.launchpad.net

Description of the change

Remove the hooks from the leadership layer. These are now provided by layer:basic:

https://github.com/juju-solutions/layer-basic/tree/master/hooks

This is needed because the layer:leadership hooks are not up to date with layer:basic. They do not do "basic.init_config_states()", which causes "config.set.X" states to be removed after leader-elected runs.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Thanks for catching this. Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/hooks/leader-elected b/hooks/leader-elected
0deleted file mode 1007550deleted file mode 100755
index fe39f65..0000000
--- a/hooks/leader-elected
+++ /dev/null
@@ -1,18 +0,0 @@
1#!/usr/bin/env python3
2
3# Load modules from $CHARM_DIR/lib
4import sys
5sys.path.append('lib')
6
7from charms.layer.basic import bootstrap_charm_deps
8bootstrap_charm_deps()
9
10
11# This will load and run the appropriate @hook and other decorated
12# handlers from $CHARM_DIR/reactive, $CHARM_DIR/hooks/reactive,
13# and $CHARM_DIR/hooks/relations.
14#
15# See https://jujucharms.com/docs/stable/authors-charm-building
16# for more information on this pattern.
17from charms.reactive import main
18main()
diff --git a/hooks/leader-settings-changed b/hooks/leader-settings-changed
19deleted file mode 1007550deleted file mode 100755
index fe39f65..0000000
--- a/hooks/leader-settings-changed
+++ /dev/null
@@ -1,18 +0,0 @@
1#!/usr/bin/env python3
2
3# Load modules from $CHARM_DIR/lib
4import sys
5sys.path.append('lib')
6
7from charms.layer.basic import bootstrap_charm_deps
8bootstrap_charm_deps()
9
10
11# This will load and run the appropriate @hook and other decorated
12# handlers from $CHARM_DIR/reactive, $CHARM_DIR/hooks/reactive,
13# and $CHARM_DIR/hooks/relations.
14#
15# See https://jujucharms.com/docs/stable/authors-charm-building
16# for more information on this pattern.
17from charms.reactive import main
18main()

Subscribers

People subscribed via source and target branches

to all changes: