Merge lp:~kwmonroe/charms/trusty/hdp-hive/trunk into lp:charms/trusty/hdp-hive

Proposed by Kevin W Monroe
Status: Merged
Merged at revision: 17
Proposed branch: lp:~kwmonroe/charms/trusty/hdp-hive/trunk
Merge into: lp:charms/trusty/hdp-hive
Diff against target: 39 lines (+5/-5)
2 files modified
files/scripts/gpg_ubuntu.sh (+2/-2)
hooks/hdputils.py (+3/-3)
To merge this branch: bzr merge lp:~kwmonroe/charms/trusty/hdp-hive/trunk
Reviewer Review Type Date Requested Status
Juju Big Data Development Pending
Review via email: mp+260889@code.launchpad.net

Description of the change

Allow keyserver access via port 80. The mit.edu keyserver used in our gpg_ubuntu.sh script supports this, and it eases the install burden for people in restricted networks (default hkp xfers happen over port 11371, which would probably not be open/forwarded in most restrictive networks; port 80 is more likely to be free).

Also pull packages from the hortonworks http site since their https certs are broken. Security implications should be minimal since we do checksum verification on the payload prior to install. This also helps in restrictive networks where 443 may be blocked (and 80 open).

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'files/scripts/gpg_ubuntu.sh'
--- files/scripts/gpg_ubuntu.sh 2014-08-11 22:30:08 +0000
+++ files/scripts/gpg_ubuntu.sh 2015-06-02 20:43:36 +0000
@@ -1,3 +1,3 @@
1#!/bin/sh1#!/bin/sh
2gpg --keyserver pgp.mit.edu --recv-keys B9733A7A07513CAD
3gpg -a --export 07513CAD | apt-key add -
4\ No newline at end of file2\ No newline at end of file
3gpg --keyserver hkp://pgp.mit.edu:80 --recv-keys B9733A7A07513CAD
4gpg -a --export 07513CAD | apt-key add -
55
=== modified file 'hooks/hdputils.py'
--- hooks/hdputils.py 2014-09-19 02:55:54 +0000
+++ hooks/hdputils.py 2015-06-02 20:43:36 +0000
@@ -61,7 +61,7 @@
61 au = ArchiveUrlFetchHandler()61 au = ArchiveUrlFetchHandler()
62 if not os.path.exists(listpath):62 if not os.path.exists(listpath):
63 listsum = '3e53ca19f2c4461a6f4246a049a73779c4e81bce'63 listsum = '3e53ca19f2c4461a6f4246a049a73779c4e81bce'
64 listurl = 'https://public-repo-1.hortonworks.com/HDP/ubuntu12/2.1.3.0/hdp.list'64 listurl = 'http://public-repo-1.hortonworks.com/HDP/ubuntu12/2.1.3.0/hdp.list'
6565
66 tmpfile = au.download_and_validate(listurl, listsum)66 tmpfile = au.download_and_validate(listurl, listsum)
67 shutil.move(tmpfile, listpath)67 shutil.move(tmpfile, listpath)
@@ -74,7 +74,7 @@
7474
75 helperpath = os.path.join(home, 'hdp_manual_install_rpm_helper_files-2.1.1.385.tar.gz')75 helperpath = os.path.join(home, 'hdp_manual_install_rpm_helper_files-2.1.1.385.tar.gz')
76 if not os.path.exists(helperpath):76 if not os.path.exists(helperpath):
77 helperurl = 'https://public-repo-1.hortonworks.com/HDP/tools/2.1.1.0/hdp_manual_install_rpm_helper_files-2.1.1.385.tar.gz'77 helperurl = 'http://public-repo-1.hortonworks.com/HDP/tools/2.1.1.0/hdp_manual_install_rpm_helper_files-2.1.1.385.tar.gz'
78 helpersum = '5b59b7c71cf5bc95b19cf8d79dee170be5ceffd1'78 helpersum = '5b59b7c71cf5bc95b19cf8d79dee170be5ceffd1'
79 tmpfile = au.download_and_validate(helperurl, helpersum)79 tmpfile = au.download_and_validate(helperurl, helpersum)
80 shutil.move(tmpfile, helperpath)80 shutil.move(tmpfile, helperpath)
@@ -177,4 +177,4 @@
177hdpScriptPath = os.path.join(os.path.sep,home, hdpScript,'scripts')177hdpScriptPath = os.path.join(os.path.sep,home, hdpScript,'scripts')
178usersAndGroupsScript = os.path.join(os.path.sep, hdpScriptPath, "usersAndGroups.sh")178usersAndGroupsScript = os.path.join(os.path.sep, hdpScriptPath, "usersAndGroups.sh")
179directoriesScript = os.path.join(os.path.sep, hdpScriptPath, "directories.sh")179directoriesScript = os.path.join(os.path.sep, hdpScriptPath, "directories.sh")
180bashrc = os.path.join(os.path.sep, home, '.bashrc')
181\ No newline at end of file180\ No newline at end of file
181bashrc = os.path.join(os.path.sep, home, '.bashrc')

Subscribers

People subscribed via source and target branches