Andrew <email address hidden> writes:
> Review: Needs Fixing > This all looks great Kalle!
Thanks for review!
> Just one small issue, FligthModeDevice should be FlightModeDevice :)
Haha, I always do the same mistake :) I should make emacs warn about this...
> The fact that this is the only issue is a credit to your work!
No, this is all credit to your work. The architecture for the settings app is just excellent, it was extremely simple to connect libconnman to it.
-- Kalle Valo
« Back to merge proposal
Andrew <email address hidden> writes:
> Review: Needs Fixing
> This all looks great Kalle!
Thanks for review!
> Just one small issue, FligthModeDevice should be FlightModeDevice :)
Haha, I always do the same mistake :) I should make emacs warn about
this...
> The fact that this is the only issue is a credit to your work!
No, this is all credit to your work. The architecture for the settings
app is just excellent, it was extremely simple to connect libconnman to
it.
--
Kalle Valo