Merge lp:~kvalo/indicator-network/bug-736867 into lp:~indicator-applet-developers/indicator-network/indicator-network

Proposed by Kalle Valo
Status: Merged
Merged at revision: 180
Proposed branch: lp:~kvalo/indicator-network/bug-736867
Merge into: lp:~indicator-applet-developers/indicator-network/indicator-network
Diff against target: 51 lines (+11/-1)
2 files modified
src/settings/frontend/widgets/dialogs/edit-connection.vala (+10/-0)
src/settings/ui/edit_connection_dialog.ui (+1/-1)
To merge this branch: bzr merge lp:~kvalo/indicator-network/bug-736867
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+54680@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Looks good to me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/settings/frontend/widgets/dialogs/edit-connection.vala'
--- src/settings/frontend/widgets/dialogs/edit-connection.vala 2011-03-18 12:42:40 +0000
+++ src/settings/frontend/widgets/dialogs/edit-connection.vala 2011-03-24 11:41:03 +0000
@@ -42,8 +42,10 @@
42 private Gtk.CheckButton checkbutton_autoconnect;42 private Gtk.CheckButton checkbutton_autoconnect;
4343
44 /* wifi */44 /* wifi */
45 private Gtk.Table table_wireless;
45 private Gtk.Label label_mode;46 private Gtk.Label label_mode;
46 private Gtk.Label label_security;47 private Gtk.Label label_security;
48 private Gtk.Label label_passphrase;
47 private Gtk.Entry entry_passphrase;49 private Gtk.Entry entry_passphrase;
4850
49 /* ipv4 */51 /* ipv4 */
@@ -220,8 +222,10 @@
220 as Gtk.CheckButton;222 as Gtk.CheckButton;
221223
222 /* wifi */224 /* wifi */
225 this.table_wireless = b.get_object("table_wireless") as Gtk.Table;
223 this.label_mode = b.get_object("label_mode") as Gtk.Label;226 this.label_mode = b.get_object("label_mode") as Gtk.Label;
224 this.label_security = b.get_object("label_security") as Gtk.Label;227 this.label_security = b.get_object("label_security") as Gtk.Label;
228 this.label_passphrase = b.get_object("label_passphrase") as Gtk.Label;
225 this.entry_passphrase = b.get_object("entry_passphrase") as Gtk.Entry;229 this.entry_passphrase = b.get_object("entry_passphrase") as Gtk.Entry;
226230
227 /* ipv4 */231 /* ipv4 */
@@ -362,6 +366,12 @@
362 }366 }
363367
364 private void update_passphrase() {368 private void update_passphrase() {
369 if (this.connection.security == Connman.ServiceSecurity.NONE) {
370 this.table_wireless.remove(this.entry_passphrase);
371 this.table_wireless.remove(this.label_passphrase);
372 return;
373 }
374
365 this.entry_passphrase.set_text(this.connection.passphrase);375 this.entry_passphrase.set_text(this.connection.passphrase);
366 }376 }
367377
368378
=== modified file 'src/settings/ui/edit_connection_dialog.ui'
--- src/settings/ui/edit_connection_dialog.ui 2011-03-17 13:28:03 +0000
+++ src/settings/ui/edit_connection_dialog.ui 2011-03-24 11:41:03 +0000
@@ -131,7 +131,7 @@
131 </packing>131 </packing>
132 </child>132 </child>
133 <child>133 <child>
134 <object class="GtkLabel" id="label14">134 <object class="GtkLabel" id="label_passphrase">
135 <property name="visible">True</property>135 <property name="visible">True</property>
136 <property name="xalign">1</property>136 <property name="xalign">1</property>
137 <property name="label" translatable="yes">Passphrase:</property>137 <property name="label" translatable="yes">Passphrase:</property>

Subscribers

People subscribed via source and target branches