Code review comment for ~kstenerud/ubuntu/+source/postfix:bionic-postconf-segfault-1753470

Hi Karl,
I think in the meantime the patch is accepted upstream and you could mark that in the patch if you want.

Dep3 has for this:
+ * `Applied-Upstream` (optional)
+
+ This field can be used to document the fact that the patch has been
+ applied upstream. It may contain the upstream version expected to
+ contain this patch, or the URL or commit identifier of the upstream
+ commit (with commit identifiers prefixed with "commit:", as in the
+ `Origin` field), or both separated by a comma and a space.

Other than it looks good to me.

For next time it would be great if you could trow also a link to a ppa with the changes built in here so I can retest without rebuilding on my own, but that isn't critical atm.

Further the Author in your commits is still set up as:
  Karl Stenerud <email address hidden>
That is fine if intentional, knowing it is the first I wanted to ask if you wanted to switch to the @canonical address for these?

The patch itself applies as-is without fuzz, builds and works.

Need-Info until the few things mentioned are clarified, but overall LGTM