Ubuntu
php7.3 package

Code review comment for ~kstenerud/ubuntu/+source/php7.3:disco-php7.3-pcre3-1806710

  1. Git
  2. lp:~kstenerud/ubuntu/+source/php7.3
  3. disco-php7.3-pcre3-1806710
  4. Merge into ubuntu/devel
Revision history for this message
Robie Basak (racb) wrote :

Looks good, thanks! Comments inline.

Also, do we need to regenerate tests/ from tests.in/ before upload? I assume we do need to do this, because the source previously contains a generated tests/ that matches tests.in/, and now it won't.

« Back to merge proposal