Merge ~kstenerud/ubuntu/+source/logwatch:cosmic-logwatch-syslog-1199511 into ubuntu/+source/logwatch:ubuntu/cosmic-devel
Status: | Rejected |
---|---|
Rejected by: | Christian Ehrhardt |
Proposed branch: | ~kstenerud/ubuntu/+source/logwatch:cosmic-logwatch-syslog-1199511 |
Merge into: | ubuntu/+source/logwatch:ubuntu/cosmic-devel |
Diff against target: |
70 lines (+22/-6) 6 files modified
debian/changelog (+8/-0) debian/dist.conf/logfiles/cron.conf (+4/-3) debian/dist.conf/logfiles/daemon.conf (+4/-3) debian/dist.conf/logfiles/kernel.conf (+2/-0) debian/dist.conf/logfiles/secure.conf (+2/-0) debian/dist.conf/logfiles/syslog.conf (+2/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Christian Ehrhardt (community) | Needs Resubmitting | ||
Canonical Server | Pending | ||
Canonical Server Core Reviewers | Pending | ||
Review via email: mp+354951@code.launchpad.net |
Description of the change
Since the changeover to rsyslogd, logwatch has been looking in the wrong places for the logfiles it's supposed to monitor.
Logs that used to go to /var/log/
Steps to test:
# lxc launch ubuntu-daily:cosmic tester
# lxc exec tester bash
# dhclient
# apt update
# apt dist-upgrade -y
# apt install -y logwatch
# echo "Sep 12 01:41:51 xxxxx named[838]: received control channel command 'refresh example.com'
Sep 12 03:34:10 xxxxx smartd[30161]: Monitoring 4 ATA and 0 SCSI devices
Sep 12 03:34:11 xxxxx smartd[30161]: Device: /dev/hdc, 463 Currently unreadable (pending) sectors
Sep 12 03:34:11 xxxxx smartd[30161]: Device: /dev/hdc, 1210 Offline uncorrectable sectors
Sep 12 03:34:11 xxxxx smartd[30161]: Device: /dev/hdd, 1430 Currently unreadable (pending) sectors
Sep 12 03:34:11 xxxxx smartd[30161]: Device: /dev/hdd, 1429 Offline uncorrectable sectors
Sep 12 09:00:00 xxxxx afpd[2383]: login noauth" >> /var/log/syslog
# logwatch --detail medium --range all --service named
# logwatch --detail medium --range all --service smartd
# logwatch --detail medium --range all --service afpd
* None of these commands will display anything.
# add-apt-repository -y ppa:kstenerud/
# apt update
# apt upgrade -y
# logwatch --detail medium --range all --service named
# logwatch --detail medium --range all --service smartd
# logwatch --detail medium --range all --service afpd
* All three commands should display report information
Package Tests:
There are no package tests in logwatch.
I'm no logwatch expert, but seeing the replaced rules should there also be an entry like this:
Archive = syslog.*.gz
To also by default read the archived data.
if we change it it would be great to test that as well and if working use it right away.
For example the cron config would otherwise loose Archive access, so I'd think we should add it (for all of them)