KiCad

Code review comment for ~kristoffer-odmark/kicad:tom-copypasta

  1. Git
  2. lp:~kristoffer-odmark/kicad
  3. tom-copypasta
  4. Merge into master
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

Kristoffer,

Please do not put license text inside Doxygen comments. I also saw
quite a few coding policy violations:

Trailing white space.

Missing spaces around function argument braces.

100 character line length exceeded.

Only one empty space (should be 2) between method definitions in .cpp
source files.

Curly bracket not on next line.

Incorrect indentation level.

Please clean these up before we merge your patch.

Thanks,

Wayne

On 9/26/2017 1:58 PM, Kristoffer wrote:
> Kristoffer has proposed merging ~kristoffer-odmark/kicad:tom-copypasta into kicad:master.
>
> Requested reviews:
> Tomasz Wlostowski (twlostow)
>
> For more details, see:
> https://code.launchpad.net/~kristoffer-odmark/kicad/+git/kicad/+merge/331369
>
> Added copy-paste functionality to pcbnew. Coworked with Tomasz. I think it is fully acceptable in the current state and ready for mainstream testing.
>
>

« Back to merge proposal