Merge ~kobako/ubuntu/+source/alsa-ucm-conf:LP2015972_J into ubuntu/+source/alsa-ucm-conf:ubuntu/jammy-proposed

Proposed by koba
Status: Needs review
Proposed branch: ~kobako/ubuntu/+source/alsa-ucm-conf:LP2015972_J
Merge into: ubuntu/+source/alsa-ucm-conf:ubuntu/jammy-proposed
Diff against target: 71 lines (+49/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch (+41/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
git-ubuntu import Pending
Review via email: mp+441279@code.launchpad.net

Description of the change

BugLink: https://bugs.launchpad.net/bugs/2015972

[Feature Description]
When users press the speaker mute hotkey and the speaker is muted,
the speaker mute LED indicator will light up.
When the speaker is not muted,
the speaker mute LED indicator will light out.

[Test Case]
1. run G16 with target kernel.
2. press the mute hotkey
3. check if speaker mute led can be switched.

[Where problems could occur]
Low, just register a speaker mute led control for dell-laptop.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your contribution, the change should not be inline though but in debian/patches and you should have a debian/changelog entry explaining the fix and referencing to the launchpad bug to close

review: Needs Fixing
Revision history for this message
koba (kobako) wrote :

@Seb128, thanks for reviewing and comment,
Have modified as per your comment,
1. add patch to debian/patches
2. add a entry in d/changelog

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've uploaded now but I don't have the right the change the status of the MP on gitubuntu

review: Approve

Unmerged commits

1f2fac4... by koba

1.2.6.3-1ubuntu1.6 (patches unapplied)

Imported using git-ubuntu import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 845c3a8..04e5892 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1alsa-ucm-conf (1.2.6.3-1ubuntu1.6) jammy; urgency=medium
2
3 * d/p/0014-sof-hda-dsp-Add-speaker-led-support.patch
4 - Backport patch to fix speaker mute led (LP: #2015972)
5
6 -- Koba Ko <koba.ko@canonical.com> Wed, 19 Apr 2023 09:14:07 +0800
7
1alsa-ucm-conf (1.2.6.3-1ubuntu1.5) jammy; urgency=medium8alsa-ucm-conf (1.2.6.3-1ubuntu1.5) jammy; urgency=medium
29
3 * d/p/0001-ucm2-HDA-Update-Mic-LED-settings-for-ACP-DMIC.patch10 * d/p/0001-ucm2-HDA-Update-Mic-LED-settings-for-ACP-DMIC.patch
diff --git a/debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch b/debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch
4new file mode 10064411new file mode 100644
index 0000000..b0dc164
--- /dev/null
+++ b/debian/patches/0014-sof-hda-dsp-Add-speaker-led-support.patch
@@ -0,0 +1,41 @@
1From fa57710ebfec1f3af78e561febc443cd3c195f2f Mon Sep 17 00:00:00 2001
2From: KobaKo <koba.ko@canonical.com>
3Date: Mon, 6 Mar 2023 20:22:51 +0800
4Subject: [PATCH] sof-hda-dsp: Add speaker led support
5
6Fixes: https://github.com/alsa-project/alsa-ucm-conf/pull/302
7Signed-off-by: KobaKo <koba.ko@canonical.com>
8Signed-off-by: Jaroslav Kysela <perex@perex.cz>
9(cherry picked from commit a2cabe3044075d53e4df0d4bb7c0818071e95e12)
10Signed-off-by: Koba Ko <koba.ko@canonical.com>
11---
12 ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf | 13 +++++++++++++
13 1 file changed, 13 insertions(+)
14
15diff --git a/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf b/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf
16index b47777b..35bd485 100644
17--- a/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf
18+++ b/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf
19@@ -51,6 +51,19 @@ If.speaker {
20 ]
21 }
22
23+If.DellMuteLed {
24+ Condition {
25+ Type String
26+ Haystack "$${sys:class/leds/platform::mute/device}"
27+ Needle "dell-laptop"
28+ }
29+ True {
30+ FixedBootSequence [
31+ sysw "-/class/sound/ctl-led/speaker/card${CardNumber}/attach:Master Playback Switch"
32+ ]
33+ }
34+}
35+
36 If.headphone {
37 Condition {
38 Type ControlExists
39--
402.34.1
41
diff --git a/debian/patches/series b/debian/patches/series
index d6dda86..a11f150 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -11,3 +11,4 @@ ucm2-sof-hda-dsp-If.devdmic-cleanup.patch
11sof-hda-dsp-Set-Dmic0-Capture-Switch-on.patch11sof-hda-dsp-Set-Dmic0-Capture-Switch-on.patch
12ucm2-sof-soundwire-Update-Mic-LED-settings.patch12ucm2-sof-soundwire-Update-Mic-LED-settings.patch
130001-ucm2-HDA-Update-Mic-LED-settings-for-ACP-DMIC.patch130001-ucm2-HDA-Update-Mic-LED-settings-for-ACP-DMIC.patch
140014-sof-hda-dsp-Add-speaker-led-support.patch

Subscribers

People subscribed via source and target branches

to all changes: