Code review comment for lp:~knitzsche/telegram-app/recent-keyword-aggreagation

Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Just a comment for Karni:
C++ 11 uses this_annotation and Qt uses thisOther ... so... it's not easy agree on one of them since everybody is right regardless of what his opinion is.

In fw we have the next "convention" for everybody to be happy:

- all c++ 11 related code uses underscore annotation
- all Qt related code uses camel case

so that you can have instructions like:

const std::atype& a_var = "a value";
const QVariant &another = QVariant("another");
QString myString = QString::fromStdString(one_object.calling_any_c_eleven_method(a_var, another));

besides, in scopes world the usual way you find code is in c++ 11 way, so that annotation can't be skipped

« Back to merge proposal