Merge lp:~knitzsche/scope-aggregator/fixes-bug-1549844-runtime-scopeid-in-log-always into lp:scope-aggregator

Proposed by Kyle Nitzsche
Status: Merged
Approved by: Kyle Nitzsche
Approved revision: 158
Merged at revision: 159
Proposed branch: lp:~knitzsche/scope-aggregator/fixes-bug-1549844-runtime-scopeid-in-log-always
Merge into: lp:scope-aggregator
Diff against target: 39 lines (+4/-4)
2 files modified
CMakeLists.txt (+1/-1)
src/query.cpp (+3/-3)
To merge this branch: bzr merge lp:~knitzsche/scope-aggregator/fixes-bug-1549844-runtime-scopeid-in-log-always
Reviewer Review Type Date Requested Status
Jin Pending
Zhang Enwei Pending
Penk Chen Pending
Gary.Wang Pending
Review via email: mp+287189@code.launchpad.net

Description of the change

always use runtime agg scope id in log messages.

https://bugs.launchpad.net/scope-aggregator/+bug/1549844

To post a comment you must log in.
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Because this is a trivial change, and because it has been a week with no review, I am going to merge it so that I can produce a new release of scope-aggregator that includes other changes so that I can rebase photos-agg and today-agg on it for ota 10.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2016-02-09 16:11:02 +0000
+++ CMakeLists.txt 2016-02-25 15:21:01 +0000
@@ -1,4 +1,4 @@
1set(VERSION "4.2.1")1set(VERSION "4.2.2")
22
3# Supress qDebug() output3# Supress qDebug() output
4ADD_DEFINITIONS( -DQT_NO_DEBUG_OUTPUT )4ADD_DEFINITIONS( -DQT_NO_DEBUG_OUTPUT )
55
=== modified file 'src/query.cpp'
--- src/query.cpp 2015-12-02 22:19:12 +0000
+++ src/query.cpp 2016-02-25 15:21:01 +0000
@@ -242,7 +242,7 @@
242 create_departments(upstream_reply);242 create_departments(upstream_reply);
243 }243 }
244 else244 else
245 qWarning () << QString("%1: NOT using departments").arg(qstr(SCOPE_ID));245 qWarning () << QString("%1: NOT using departments").arg(qstr(scope_id));
246246
247 // set up handling for results and handle them, including buffering to ensure order247 // set up handling for results and handle them, including buffering to ensure order
248 handle_child_scope_results(query_string, empty_search, upstream_reply);248 handle_child_scope_results(query_string, empty_search, upstream_reply);
@@ -301,7 +301,7 @@
301 us::MetadataMap::const_iterator scope_it;301 us::MetadataMap::const_iterator scope_it;
302 scope_it = reg_scopes.find(localId_id_m[local_id]);302 scope_it = reg_scopes.find(localId_id_m[local_id]);
303 if (scope_it == reg_scopes.end()) {303 if (scope_it == reg_scopes.end()) {
304 qWarning () << QString("%1: scope is NOT REGISTERED, skipping: %2").arg(qstr(SCOPE_ID), qstr(localId_id_m[local_id]));304 qWarning () << QString("%1: scope is NOT REGISTERED, skipping: %2").arg(qstr(scope_id), qstr(localId_id_m[local_id]));
305 continue;305 continue;
306 }306 }
307307
@@ -332,7 +332,7 @@
332332
333 if (!found_as_enabled)333 if (!found_as_enabled)
334 {334 {
335 qWarning () << QString("%1: scope is NOT ENABLED, skipping: %2").arg(qstr(SCOPE_ID), qstr(localId_id_m[local_id]));335 qWarning () << QString("%1: scope is NOT ENABLED, skipping: %2").arg(qstr(scope_id), qstr(localId_id_m[local_id]));
336 continue;336 continue;
337 }337 }
338338

Subscribers

People subscribed via source and target branches