Merge lp:~knitzsche/scope-aggregator/fixes-bug-1549844-runtime-scopeid-in-log-always into lp:scope-aggregator

Proposed by Kyle Nitzsche
Status: Merged
Approved by: Kyle Nitzsche
Approved revision: 158
Merged at revision: 159
Proposed branch: lp:~knitzsche/scope-aggregator/fixes-bug-1549844-runtime-scopeid-in-log-always
Merge into: lp:scope-aggregator
Diff against target: 39 lines (+4/-4)
2 files modified
CMakeLists.txt (+1/-1)
src/query.cpp (+3/-3)
To merge this branch: bzr merge lp:~knitzsche/scope-aggregator/fixes-bug-1549844-runtime-scopeid-in-log-always
Reviewer Review Type Date Requested Status
Jin Pending
Zhang Enwei Pending
Penk Chen Pending
Gary.Wang Pending
Review via email: mp+287189@code.launchpad.net

Description of the change

always use runtime agg scope id in log messages.

https://bugs.launchpad.net/scope-aggregator/+bug/1549844

To post a comment you must log in.
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Because this is a trivial change, and because it has been a week with no review, I am going to merge it so that I can produce a new release of scope-aggregator that includes other changes so that I can rebase photos-agg and today-agg on it for ota 10.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2016-02-09 16:11:02 +0000
3+++ CMakeLists.txt 2016-02-25 15:21:01 +0000
4@@ -1,4 +1,4 @@
5-set(VERSION "4.2.1")
6+set(VERSION "4.2.2")
7
8 # Supress qDebug() output
9 ADD_DEFINITIONS( -DQT_NO_DEBUG_OUTPUT )
10
11=== modified file 'src/query.cpp'
12--- src/query.cpp 2015-12-02 22:19:12 +0000
13+++ src/query.cpp 2016-02-25 15:21:01 +0000
14@@ -242,7 +242,7 @@
15 create_departments(upstream_reply);
16 }
17 else
18- qWarning () << QString("%1: NOT using departments").arg(qstr(SCOPE_ID));
19+ qWarning () << QString("%1: NOT using departments").arg(qstr(scope_id));
20
21 // set up handling for results and handle them, including buffering to ensure order
22 handle_child_scope_results(query_string, empty_search, upstream_reply);
23@@ -301,7 +301,7 @@
24 us::MetadataMap::const_iterator scope_it;
25 scope_it = reg_scopes.find(localId_id_m[local_id]);
26 if (scope_it == reg_scopes.end()) {
27- qWarning () << QString("%1: scope is NOT REGISTERED, skipping: %2").arg(qstr(SCOPE_ID), qstr(localId_id_m[local_id]));
28+ qWarning () << QString("%1: scope is NOT REGISTERED, skipping: %2").arg(qstr(scope_id), qstr(localId_id_m[local_id]));
29 continue;
30 }
31
32@@ -332,7 +332,7 @@
33
34 if (!found_as_enabled)
35 {
36- qWarning () << QString("%1: scope is NOT ENABLED, skipping: %2").arg(qstr(SCOPE_ID), qstr(localId_id_m[local_id]));
37+ qWarning () << QString("%1: scope is NOT ENABLED, skipping: %2").arg(qstr(scope_id), qstr(localId_id_m[local_id]));
38 continue;
39 }
40

Subscribers

People subscribed via source and target branches