Merge lp:~knitzsche/dotdepends/fixes-1018582 into lp:dotdepends

Proposed by Kyle Nitzsche
Status: Merged
Merged at revision: 44
Proposed branch: lp:~knitzsche/dotdepends/fixes-1018582
Merge into: lp:dotdepends
Diff against target: 67 lines (+19/-4)
3 files modified
Dotdepends/Dot.py (+9/-1)
data/dotdepends.1 (+2/-3)
debian/changelog (+8/-0)
To merge this branch: bzr merge lp:~knitzsche/dotdepends/fixes-1018582
Reviewer Review Type Date Requested Status
Mike Carifio Approve
Review via email: mp+112430@code.launchpad.net

Description of the change

fixes-1018582
and man page indentation error

To post a comment you must log in.
Revision history for this message
Mike Carifio (carifio) wrote :

line 9: 'gerated' -> 'generated'

Revision history for this message
Mike Carifio (carifio) wrote :

don't need to see you fix the typo

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Dotdepends/Dot.py'
--- Dotdepends/Dot.py 2012-06-22 17:04:02 +0000
+++ Dotdepends/Dot.py 2012-06-27 20:52:17 +0000
@@ -188,10 +188,18 @@
188 return fams188 return fams
189189
190 def remove_root_family(self, fams, root):190 def remove_root_family(self, fams, root):
191 """If the root node is found to be summarizable as a family, remove it
192 from the dictionary of families in order to keep the gerated data
193 clear. That is, all direct depends of the root node should be separate
194 nodes rather than being included in the top level famliy."""
195
191 if root == "":196 if root == "":
192 print "Error. You must set the root package (node) with -r PKG. Stopping"197 print "Error. You must set the root package (node) with -r PKG. Stopping"
193 sys.exit(1)198 sys.exit(1)
194 del fams[root]199 try:
200 fams.pop(root)
201 except KeyError:
202 pass # it's OK if the root node is not a family
195 return fams203 return fams
196204
197 def process_families(self,fams):205 def process_families(self,fams):
198206
=== modified file 'data/dotdepends.1'
--- data/dotdepends.1 2012-06-22 17:04:02 +0000
+++ data/dotdepends.1 2012-06-27 20:52:17 +0000
@@ -27,7 +27,6 @@
27.br27.br
28.SS28.SS
29\fBSpecify the Mode\fR: You can generate a single detailed (no families) graph (and related files) for the PKG's \fBdependencies\fR or for its \fBreverse dependencies\fR with the \fB-m MODE\fR argument, for example: \fBdotdepends -m rdepends gedit\fR.29\fBSpecify the Mode\fR: You can generate a single detailed (no families) graph (and related files) for the PKG's \fBdependencies\fR or for its \fBreverse dependencies\fR with the \fB-m MODE\fR argument, for example: \fBdotdepends -m rdepends gedit\fR.
30.HP
31This mode produces (a dot and) a png that is defined by the scope specified by command arguments. For example, one can include recommends with the \fB-r\fR argument, and one can limit rdepends to installed packages with the \fB-i\fR argument.30This mode produces (a dot and) a png that is defined by the scope specified by command arguments. For example, one can include recommends with the \fB-r\fR argument, and one can limit rdepends to installed packages with the \fB-i\fR argument.
32.br31.br
33The generated file name is reported on stdout. The file name describes the scope of execution as defined by the relevant arguments. For example: fontconfig-depends-Installed-NoRecommends-NoSuggests-NoEnhances.png is: for fontconfig package, in depends mode, limited to installed packages, with no recommends, no suggests, and no enhances packages included.32The generated file name is reported on stdout. The file name describes the scope of execution as defined by the relevant arguments. For example: fontconfig-depends-Installed-NoRecommends-NoSuggests-NoEnhances.png is: for fontconfig package, in depends mode, limited to installed packages, with no recommends, no suggests, and no enhances packages included.
@@ -38,13 +37,13 @@
38.br37.br
39.SS \fBColors\fR38.SS \fBColors\fR
40.HP39.HP
41\fBBlack box borders\fR show packages or package families that would always be installed due to depends. (If the family contains a member that is only recommended -- has no depends on it -- then the box is still black bordered. However, you can see such internal details in the DETAIL png.)40\fBBlack box borders\fR show packages or package families that would always be installed due to depends. (If the family contains a member that is only recommended -- has no depends on it -- then the family box is still black bordered. However, you can see such internal details in the DETAIL png.)
42.HP41.HP
43\fBRed box borders\fR show packages or package families that would only be installed if Install-Recommends is enabled.42\fBRed box borders\fR show packages or package families that would only be installed if Install-Recommends is enabled.
44.HP43.HP
45\fBBlack arrows\fR show depends relationships.44\fBBlack arrows\fR show depends relationships.
46.HP45.HP
47\fBRed arrows\fR show depends relationships.46\fBRed arrows\fR show recommends relationships.
48.HP47.HP
49\fBYellow filled boxes\fR are family nodes.48\fBYellow filled boxes\fR are family nodes.
50.HP49.HP
5150
=== modified file 'debian/changelog'
--- debian/changelog 2012-06-26 13:42:16 +0000
+++ debian/changelog 2012-06-27 20:52:17 +0000
@@ -1,3 +1,11 @@
1dotdepends (0.3.9) precise; urgency=low
2
3 * Dont' crash when removing the root node family from the dictionary of
4 families when there are no found families. (LP: #1018582)
5 * Fix indentation error in dotdepends man page.
6
7 -- Kyle Nitzsche <kyle.nitzsche@canonical.com> Wed, 27 Jun 2012 16:40:58 -0400
8
1dotdepends (0.3.8) precise; urgency=low9dotdepends (0.3.8) precise; urgency=low
210
3 * debian/control: Added Build-Depends: python-nose11 * debian/control: Added Build-Depends: python-nose

Subscribers

People subscribed via source and target branches

to all changes: