Merge lp:~knitzsche/dotdepends/fixes-1018582 into lp:dotdepends

Proposed by Kyle Nitzsche
Status: Merged
Merged at revision: 44
Proposed branch: lp:~knitzsche/dotdepends/fixes-1018582
Merge into: lp:dotdepends
Diff against target: 67 lines (+19/-4)
3 files modified
Dotdepends/Dot.py (+9/-1)
data/dotdepends.1 (+2/-3)
debian/changelog (+8/-0)
To merge this branch: bzr merge lp:~knitzsche/dotdepends/fixes-1018582
Reviewer Review Type Date Requested Status
Mike Carifio Approve
Review via email: mp+112430@code.launchpad.net

Description of the change

fixes-1018582
and man page indentation error

To post a comment you must log in.
Revision history for this message
Mike Carifio (carifio) wrote :

line 9: 'gerated' -> 'generated'

Revision history for this message
Mike Carifio (carifio) wrote :

don't need to see you fix the typo

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Dotdepends/Dot.py'
2--- Dotdepends/Dot.py 2012-06-22 17:04:02 +0000
3+++ Dotdepends/Dot.py 2012-06-27 20:52:17 +0000
4@@ -188,10 +188,18 @@
5 return fams
6
7 def remove_root_family(self, fams, root):
8+ """If the root node is found to be summarizable as a family, remove it
9+ from the dictionary of families in order to keep the gerated data
10+ clear. That is, all direct depends of the root node should be separate
11+ nodes rather than being included in the top level famliy."""
12+
13 if root == "":
14 print "Error. You must set the root package (node) with -r PKG. Stopping"
15 sys.exit(1)
16- del fams[root]
17+ try:
18+ fams.pop(root)
19+ except KeyError:
20+ pass # it's OK if the root node is not a family
21 return fams
22
23 def process_families(self,fams):
24
25=== modified file 'data/dotdepends.1'
26--- data/dotdepends.1 2012-06-22 17:04:02 +0000
27+++ data/dotdepends.1 2012-06-27 20:52:17 +0000
28@@ -27,7 +27,6 @@
29 .br
30 .SS
31 \fBSpecify the Mode\fR: You can generate a single detailed (no families) graph (and related files) for the PKG's \fBdependencies\fR or for its \fBreverse dependencies\fR with the \fB-m MODE\fR argument, for example: \fBdotdepends -m rdepends gedit\fR.
32-.HP
33 This mode produces (a dot and) a png that is defined by the scope specified by command arguments. For example, one can include recommends with the \fB-r\fR argument, and one can limit rdepends to installed packages with the \fB-i\fR argument.
34 .br
35 The generated file name is reported on stdout. The file name describes the scope of execution as defined by the relevant arguments. For example: fontconfig-depends-Installed-NoRecommends-NoSuggests-NoEnhances.png is: for fontconfig package, in depends mode, limited to installed packages, with no recommends, no suggests, and no enhances packages included.
36@@ -38,13 +37,13 @@
37 .br
38 .SS \fBColors\fR
39 .HP
40-\fBBlack box borders\fR show packages or package families that would always be installed due to depends. (If the family contains a member that is only recommended -- has no depends on it -- then the box is still black bordered. However, you can see such internal details in the DETAIL png.)
41+\fBBlack box borders\fR show packages or package families that would always be installed due to depends. (If the family contains a member that is only recommended -- has no depends on it -- then the family box is still black bordered. However, you can see such internal details in the DETAIL png.)
42 .HP
43 \fBRed box borders\fR show packages or package families that would only be installed if Install-Recommends is enabled.
44 .HP
45 \fBBlack arrows\fR show depends relationships.
46 .HP
47-\fBRed arrows\fR show depends relationships.
48+\fBRed arrows\fR show recommends relationships.
49 .HP
50 \fBYellow filled boxes\fR are family nodes.
51 .HP
52
53=== modified file 'debian/changelog'
54--- debian/changelog 2012-06-26 13:42:16 +0000
55+++ debian/changelog 2012-06-27 20:52:17 +0000
56@@ -1,3 +1,11 @@
57+dotdepends (0.3.9) precise; urgency=low
58+
59+ * Dont' crash when removing the root node family from the dictionary of
60+ families when there are no found families. (LP: #1018582)
61+ * Fix indentation error in dotdepends man page.
62+
63+ -- Kyle Nitzsche <kyle.nitzsche@canonical.com> Wed, 27 Jun 2012 16:40:58 -0400
64+
65 dotdepends (0.3.8) precise; urgency=low
66
67 * debian/control: Added Build-Depends: python-nose

Subscribers

People subscribed via source and target branches

to all changes: