Merge lp:~knitzsche/dotdepends/bug-1025308 into lp:dotdepends

Proposed by Kyle Nitzsche
Status: Merged
Approved by: Kyle Nitzsche
Approved revision: 78
Merged at revision: 78
Proposed branch: lp:~knitzsche/dotdepends/bug-1025308
Merge into: lp:dotdepends
Diff against target: 26 lines (+8/-0)
2 files modified
debian/changelog (+7/-0)
usr/bin/dotdepends (+1/-0)
To merge this branch: bzr merge lp:~knitzsche/dotdepends/bug-1025308
Reviewer Review Type Date Requested Status
Mike Carifio Approve
Review via email: mp+115173@code.launchpad.net

Description of the change

dotdepends was ignoring reported apt-cache dependencies that start with a pipe (these kick off a set of pkgs any one of which can satisfy the dependency). Details: https://bugs.launchpad.net/dotdepends/+bug/1025308/

this merge adds the first such dependency to dotdepends. the others represent not standard solutions to a pkg installation and may be excluded for now.

To post a comment you must log in.
Revision history for this message
Mike Carifio (carifio) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-07-11 21:26:05 +0000
+++ debian/changelog 2012-07-16 15:29:19 +0000
@@ -1,3 +1,10 @@
1dotdepends (0.3.17kyle1) UNRELEASED; urgency=low
2
3 * Fix exclusion of Depends lines reports by apt-cache that start with "|".
4 LP: #1025308
5
6 -- Kyle Nitzsche <kyle.nitzsche@canonical.com> Mon, 16 Jul 2012 11:12:47 -0400
7
1dotdepends (0.3.17) precise; urgency=low8dotdepends (0.3.17) precise; urgency=low
29
3 * addresses non unit test review comments10 * addresses non unit test review comments
411
=== modified file 'usr/bin/dotdepends'
--- usr/bin/dotdepends 2012-07-11 20:17:42 +0000
+++ usr/bin/dotdepends 2012-07-16 15:29:19 +0000
@@ -67,6 +67,7 @@
67 if line.startswith('Reverse Depends:'): continue67 if line.startswith('Reverse Depends:'): continue
68 if line.startswith(' '): continue68 if line.startswith(' '): continue
69 line = line.lstrip()69 line = line.lstrip()
70 line = line.lstrip('|') # don't exclude leading '|' dependencies
70 if len(line) < 1: continue71 if len(line) < 1: continue
71 aRecommend = False72 aRecommend = False
72 aDep = False73 aDep = False

Subscribers

People subscribed via source and target branches

to all changes: