Code review comment for lp:~knielsen/ourdelta/bug_484127_484120_2

Revision history for this message
Kristian Nielsen (knielsen) wrote :

Hi Arjen,

This is what I did so far:

1. Update tarbake51.sh

2. Update autobake51-bintar.sh

3. Update autobake51-deb.sh (and files in bakery/debian-5.1).

I pushed this to

    lp:~knielsen/ourdelta/ourdelta-mariadb-5.1.41-knielsen

Check commit comments for details.

I also merged this with my bugfixes which are not yet merged into lp:ourdelta,
pushed here:

    lp:~maria-captains/ourdelta/ourdelta-montyprogram-fixes

I am now running Buildbot tests on this. I still need to check that upgrade
from MariadB-5.1.39 to MariaDB-5.1.41 on Debian/Ubuntu go smoothly despite the
change ourdelta->mariadb (I hope to automate this in Buildbot, else will check
manually).

For Centos, the "OurDelta" is part of the package name, so the upgrade issue
may be harder? This is beyond my .rpm skills, I assume some conflict/replaces
headers could be added?. Or maybe we can just have users uninstall 5.1.39
manually (it's a beta after all and I don't know if there are any users out
there?).

Arjen Lentz <email address hidden> writes:

> Subject: Re: [Merge] lp:~knielsen/ourdelta/bug_484127_484120_2 into lp:ourdelta
> Review: Approve
> Ok.
> --
> https://code.launchpad.net/~knielsen/ourdelta/bug_484127_484120_2/+merge/16212
> You are the owner of lp:~knielsen/ourdelta/bug_484127_484120_2.

Remember that this needs to be merged before the final release build! (A merge
is available in lp:~maria-captains/ourdelta/ourdelta-montyprogram-fixes, but
it automerges cleanly in any case).

 - Kristian.

« Back to merge proposal