Code review comment for lp:~klyachin/gomaasapi/101-testserver-extensions

Revision history for this message
Vladislav Klyachin (klyachin) wrote :

Reviewers: mp+214961_code.launchpad.net,

Message:
Please take a look.

Description:
testservice: version/network/details support

These changes are for juju-core project testing. They include new API
endpoints:

- /version/
   return capabilities, currently only networks-management
- /network/<name>/?op=list_connected_macs
   returns list of MAC addresses connected to a network
- /nodes/<system_id>/?op=details
   returns lshw XML as application/bson, the XML data should be added
before with AddNodeDetails(systemId, xml) function

Now for API endpoint:
   /networks?node=system_id
TestService returns empty list if node is not found or no networks are
connected to the node.
It panicked before.

https://code.launchpad.net/~klyachin/gomaasapi/101-testserver-extensions/+merge/214961

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/86070043/

Affected files (+277, -6 lines):
   A [revision details]
   M testservice.go
   M testservice_test.go

« Back to merge proposal