Code review comment for lp:~klaus-halfmann/widelands/bug-1395278-wui

Revision history for this message
SirVer (sirver) wrote :

Travis fails, because you have to fix one CMakeTarget: /home/travis/build/widelands/widelands/src/ai/CMakeLists.txt:1: ai misses DEPENDS on base_time_string, because it includes base/time_string.h

you can get these warnings locally by running 'make codecheck'

otherwise lgtm.

review: Approve

« Back to merge proposal