Merge lp:~klap-in/compiz-plugins-main/bug904205 into lp:compiz-plugins-main

Proposed by klap-in
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 34
Merged at revision: 34
Proposed branch: lp:~klap-in/compiz-plugins-main/bug904205
Merge into: lp:compiz-plugins-main
Diff against target: 49 lines (+10/-10)
1 file modified
wall/src/wall.cpp (+10/-10)
To merge this branch: bzr merge lp:~klap-in/compiz-plugins-main/bug904205
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Review via email: mp+112897@code.launchpad.net

Description of the change

Using the next/previous bindings the wall plugin didn't calculate correctly the next workspace when it reachs the begin or the end of a row of workspaces, so it didn't jump to the next line.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'wall/src/wall.cpp'
--- wall/src/wall.cpp 2012-05-09 01:57:02 +0000
+++ wall/src/wall.cpp 2012-06-30 11:28:18 +0000
@@ -737,17 +737,17 @@
737 if ((vpX == (unsigned int) size.width () - 1) &&737 if ((vpX == (unsigned int) size.width () - 1) &&
738 (vpY == (unsigned int) size.height () - 1))738 (vpY == (unsigned int) size.height () - 1))
739 {739 {
740 amountX = -(size.width () - 1);740 amountX = size.width () - 1;
741 amountY = -(size.height () - 1);741 amountY = size.height () - 1;
742 }742 }
743 else if (vpX == (unsigned int) size.width () - 1)743 else if (vpX == (unsigned int) size.width () - 1)
744 {744 {
745 amountX = -(size.width () - 1);745 amountX = size.width () - 1;
746 amountY = 1;746 amountY = -1;
747 }747 }
748 else748 else
749 {749 {
750 amountX = 1;750 amountX = -1;
751 amountY = 0;751 amountY = 0;
752 }752 }
753753
@@ -755,17 +755,17 @@
755 case Prev:755 case Prev:
756 if (vpX == 0 && vpY == 0)756 if (vpX == 0 && vpY == 0)
757 {757 {
758 amountX = size.width () - 1;758 amountX = -(size.width () - 1);
759 amountY = size.height () - 1;759 amountY = -(size.height () - 1);
760 }760 }
761 else if (vpX == 0)761 else if (vpX == 0)
762 {762 {
763 amountX = size.width () - 1;763 amountX = -(size.width () - 1);
764 amountY = -1;764 amountY = 1;
765 }765 }
766 else766 else
767 {767 {
768 amountX = -1;768 amountX = 1;
769 amountY = 0;769 amountY = 0;
770 }770 }
771 break;771 break;

Subscribers

People subscribed via source and target branches

to all changes: