Code review comment for lp:~kjtehprogrammer/pantheon-files/editable-pathbar
Revision history for this message
| KJ Lawrence (kjtehprogrammer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
1. The network URI support was actually what I initially started all of this for, the rest was just kind of fill in place. Though, it was just for being able to type in the path, versus using the network dialog box. I can dig into the tab issue and see what I can find.
2. I didn't see that with normal files usage. Just clicking a folder in the normal view was correct, it just appended the extra breadcrumb entry without re-rendering. Though, I did notice that if you click any of the breadcrumbs that it re-renders. Apparently that's the way the existing Files setup is, so I'd have to dig into that to make it a little more smooth. It does it somewhere though, so this shouldn't be too difficult.
3. It does this for the current Files code too - not really sure why, I'd have to dig into it. It re-renders for any of the breadcrumbs that are clicked (but doesn't redraw all of the breadcrumbs when you're just navigating around, which is kind of strange).