Code review comment for lp:~kjtehprogrammer/pantheon-files/editable-pathbar

Revision history for this message
Avi Romanoff (aroman) wrote :

Looking really good, but I have three minor issues:

1. Network URI support (which is apparently being targeted by this bug as well) is still buggy. Specifically, typing a URI (ex: `afp://Wan.local/`) does in fact cause Files to display a prompt for username/password, but it also causes the tab bar to show "This folder does not exist", and this title does not go away even when the credentials are entered and the share is loaded.

See: http://i.imgur.com/kL7HB1U.png

I dunno if this is actually supposed to be fixed by this branch, but https://bugs.launchpad.net/pantheon-files/+bug/1123059 is linked.

2. When changing directories, the whole pathbar animates, even if most the breadcrumb hierarchy stayed constant. For example, clicking on a directory "foo" inside ~/Developer/test/foo causes the entire pathbar to be re-drawn/re-animated/re-slide-in, when what should happen is only the "/foo" breadcrumb should be appended/animated in.

3. Clicking on the right-most breadcrumb causes the pathbar to re-animate. Why?

review: Needs Fixing

« Back to merge proposal