Code review comment for lp:~kjtehprogrammer/pantheon-files/editable-pathbar

Revision history for this message
Avi Romanoff (aroman) wrote :

A few things from an end-user's perspective (haven't even looked at the code)

1. Unlike other entry fields, I can't use <ctrl>+left/right to jump between words. In this case, words = directories. This is really important, I think.

2. Similar to #1, <ctrl>+a doesn't select-all. It should. (Shouldn't we get #1 and #2 for free?)

3. Typing ~/some_dir does not resolve to /home/$USER/some_dir. Instead, it looks like it's resolving to /some_dir.

4. I shouldn't be able to bread-crumb-ize non-existent paths. See: http://i.imgur.com/hxhuba8.png

review: Needs Fixing

« Back to merge proposal