Code review comment for lp:~kiwinote/software-properties/bug1042180

Revision history for this message
Michael Vogt (mvo) wrote :

On Tue, Aug 28, 2012 at 01:33:19PM -0000, Kiwinote wrote:
> Kiwinote has proposed merging lp:~kiwinote/software-properties/bug1042180 into lp:software-properties.
>
> Requested reviews:
> Michael Vogt (mvo)
>
> For more details, see:
> https://code.launchpad.net/~kiwinote/software-properties/bug1042180/+merge/121611
> --
> https://code.launchpad.net/~kiwinote/software-properties/bug1042180/+merge/121611
> You are requested to review the proposed merge of lp:~kiwinote/software-properties/bug1042180 into lp:software-properties.

Perfect, many thanks!

> === modified file 'debian/changelog'
> --- debian/changelog 2012-08-27 08:13:24 +0000
> +++ debian/changelog 2012-08-28 13:32:19 +0000
> @@ -1,3 +1,10 @@
> +software-properties (0.92.1) UNRELEASED; urgency=low
> +
> + * softwareproperties/gtk/SoftwarePropertiesGtk.py:
> + - add missing import to unblock startup (LP: #1042180)
> +
> + -- Kiwinote <email address hidden> Tue, 28 Aug 2012 15:22:59 +0200
> +
> software-properties (0.92) quantal; urgency=low
>
> [ Robert Roth ]
>
> === modified file 'softwareproperties/gtk/SoftwarePropertiesGtk.py'
> --- softwareproperties/gtk/SoftwarePropertiesGtk.py 2012-08-27 07:42:37 +0000
> +++ softwareproperties/gtk/SoftwarePropertiesGtk.py 2012-08-28 13:32:19 +0000
> @@ -28,6 +28,7 @@
> import apt_pkg
> import dbus
> from gettext import gettext as _
> +import gettext
> import os
> import subprocess
> from aptdaemon import client
>

« Back to merge proposal