Merge ~kissiel/plainbox-provider-checkbox:fix-verify-lxd into plainbox-provider-checkbox:master

[Maciej Kisielewski]

make verify_lxd job run as root

Some systems may not be preconfigured to run lxd as an unprivileged user, so this MR should help with running the job on those systems.

[Jonathan Cave (jocave)]

I guess this is ok - feels like in some situations it would be a requirement to *not* be root though. I sounds like you have a real use-case so +1

review: Approve

[Jeff Lane  (bladernr)]

Was this actually a failing issue on devices? IIRC LXD is designed to run by non-privileged users by default. Simply installing LXD and running lxd-init as a normal user should be sufficient. Running it as root shouldn't be necessary at all.

One gotcha we DID discover though is that if you do a sosreport BEFORE you run the LXD tests, you'll find the LXD tests won't work, because sosreport runs as root, and can trigger some LXD stuff, changing the ownership of some of the files to root, making it impossible at that point for a non-privileged user to run lxc commands.

This was fixed on our sosreport jobs by adding '-n lxd' to the sosreport command line to tell it to skip any LXD stuff.

[Maciej Kisielewski (kissiel)]

Yeah, I tested Jeff's hypothesis and yeah, it was my knee-jerk reaction to just add this. If the problem arises in the future I'll dig deeper.

review: Disapprove

Unmerged commits

63ae6a2... by Maciej Kisielewski on 2020-08-11

virtualization: run verify_lxd as root

diff --git a/units/virtualization/jobs.pxu b/units/virtualization/jobs.pxu
index 9471031..ac8f2c7 100644
--- a/units/virtualization/jobs.pxu
+++ b/units/virtualization/jobs.pxu
@@ -20,6 +20,7 @@ category_id: com.canonical.plainbox::virtualization
 id: virtualization/verify_lxd
 environ: LXD_TEMPLATE LXD_ROOTFS
 estimated_duration: 30.0
+user: root
 requires:
  executable.name == 'lxc'
  package.name == 'lxd' or snap.name == 'lxd'