Code review comment for ~kissiel/hwcert-tools:add-beta-snap-build-step

Revision history for this message
Taihsiang Ho (tai271828) wrote :

I realized the reboot test of smoke-test[1] could not trace the this test script as well and not only make the mini-ci itself confused. Please see my line comments.

The first thing came to my mind is to prepare another specific test plan for mini-ci rather than an updated test script and changing the flow of the current mini-ci, because it is easier and won't affect the other components in the mini-ci flow, which is not designated to be able to trace reboot status.

[1]

------------[ Running job 471 / 494. Estimated time left: unknown ]-------------
---------------------------[ Perform warm reboot 1 ]----------------------------
ID: 2013.com.canonical.certification::warm-boot-loop-reboot1
Category: 2013.com.canonical.certification::stress-tests/warm-boot
Waiting for the system to shut down or reboot...
Created symlink from /etc/systemd/system/multi-user.target.wants/plainbox-autostart.service to /etc/systemd/system/plainbox-autostart.service.
... 8< -------------------------------------------------------------------------
Connection to 10.101.48.116 closed by remote host.
Connection to 10.101.48.116 closed.

review: Needs Fixing

« Back to merge proposal