lp:~kissiel/checkbox/validation-rework

Created by Maciej Kisielewski on 2016-09-28 and last modified on 2016-09-28
Get this branch:
bzr branch lp:~kissiel/checkbox/validation-rework
Only Maciej Kisielewski can upload to this branch. If you are Maciej Kisielewski please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Maciej Kisielewski
Project:
Checkbox
Status:
Merged

Recent revisions

4514. By Maciej Kisielewski on 2016-09-28

plainbox:unit: make validation work on validator instances ONLY

Previously field_validators of any unit could be a IFieldValidator instance, a
IFieldValidator descendant, or a list containg any of the previous two.
This was unintuitive, and as measurements shown, subotimal.

This patch replaces all that with instances.

It introduces concrete_validators module that contains commonly used
validators, so callees don't have to re-instantiate them.

Signed-off-by: Maciej Kisielewski <email address hidden>

4513. By Maciej Kisielewski on 2016-09-28

plainbox:unit:manifest apply MemberOf validator

Signed-off-by: Maciej Kisielewski <email address hidden>

4512. By Maciej Kisielewski on 2016-09-28

plainbox:unit:file: use MemberOfFieldValidator in File validator

Signed-off-by: Maciej Kisielewski <email address hidden>

4511. By Maciej Kisielewski on 2016-09-28

plainbox:unit:job: use MemberOf validator in job validation

Signed-off-by: Maciej Kisielewski <email address hidden>

4510. By Maciej Kisielewski on 2016-09-28

plainbox:unit:validators: add MemberOfFieldValidator

That should be used to check whether value is known (like a plugin type)

Signed-off-by: Maciej Kisielewski <email address hidden>

4509. By Launchpad Translations on behalf of checkbox-dev on 2016-09-28

Launchpad automatic translations update.

4508. By Sylvain Pineau on 2016-09-23

"automatic merge of lp:~sylvain-pineau/checkbox/mute_job_ouput_flag/ by tarmac [r=pierre-equoy][bug=1626031][author=sylvain-pineau]"

4507. By Pierre Equoy on 2016-09-22

"automatic merge of lp:~pierre-equoy/checkbox/1560319-packaging-meta-data/ by tarmac [r=sylvain-pineau][bug=1560319][author=pierre-equoy]"

4506. By Chris Wayne on 2016-09-21

"automatic merge of lp:~cwayne18/checkbox/snappy-restart-fix/ by tarmac [r=sylvain-pineau][bug=][author=cwayne18]"

4505. By Pierre Equoy on 2016-09-21

"automatic merge of lp:~pierre-equoy/checkbox/1625884-remove-job-description-if-job-automatically-skipped/ by tarmac [r=sylvain-pineau][bug=1625884][author=pierre-equoy]"

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:checkbox
This branch contains Public information 
Everyone can see this information.