Code review comment for lp:~kissiel/checkbox/session-storage-renames

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

> Apart from the small typo (see below), it looks good to me!
>
> I tried to brutalize it by passing weird characters but it slugifies
> everything, so it's OK (well, Chinese words end up like a bunch of underscores
> but I guess the point is to be able to quickly name a session when testing, so
> it's not a big deal)

All in all there was too much 'all' :)
Fixed and repushed

« Back to merge proposal