Merge lp:~kissiel/checkbox/mandatory-jobs into lp:checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3959
Merged at revision: 3959
Proposed branch: lp:~kissiel/checkbox/mandatory-jobs
Merge into: lp:checkbox
Diff against target: 74 lines (+57/-0)
1 file modified
plainbox/plainbox/impl/session/test_resume.py (+57/-0)
To merge this branch: bzr merge lp:~kissiel/checkbox/mandatory-jobs
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+269011@code.launchpad.net

Description of the change

This MR adds the missing tests for SessionPeekHelpers.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plainbox/plainbox/impl/session/test_resume.py'
--- plainbox/plainbox/impl/session/test_resume.py 2015-08-20 11:17:46 +0000
+++ plainbox/plainbox/impl/session/test_resume.py 2015-08-25 08:17:34 +0000
@@ -42,6 +42,7 @@
42from plainbox.impl.session.resume import IncompatibleJobError42from plainbox.impl.session.resume import IncompatibleJobError
43from plainbox.impl.session.resume import IncompatibleSessionError43from plainbox.impl.session.resume import IncompatibleSessionError
44from plainbox.impl.session.resume import ResumeDiscardQualifier44from plainbox.impl.session.resume import ResumeDiscardQualifier
45from plainbox.impl.session.resume import SessionPeekHelper
45from plainbox.impl.session.resume import SessionResumeError46from plainbox.impl.session.resume import SessionResumeError
46from plainbox.impl.session.resume import SessionResumeHelper47from plainbox.impl.session.resume import SessionResumeHelper
47from plainbox.impl.session.resume import SessionResumeHelper148from plainbox.impl.session.resume import SessionResumeHelper1
@@ -184,6 +185,62 @@
184 self.assertEqual(str(boom.exception), "Unsupported version 7")185 self.assertEqual(str(boom.exception), "Unsupported version 7")
185186
186187
188class SessionPeekHelperTests(TestCase):
189
190 @mock.patch('plainbox.impl.session.resume.SessionPeekHelper1')
191 def test_peek_dispatch_v1(self, mocked_helper1):
192 data = gzip.compress(
193 b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
194 b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
195 b'},"results":{}},"version":1}')
196 SessionPeekHelper().peek(data)
197 mocked_helper1.resume_json.assertCalledOnce()
198
199 @mock.patch('plainbox.impl.session.resume.SessionPeekHelper2')
200 def test_peek_dispatch_v2(self, mocked_helper2):
201 data = gzip.compress(
202 b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
203 b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
204 b'},"results":{}},"version":2}')
205 SessionPeekHelper().peek(data)
206 mocked_helper2.resume_json.assertCalledOnce()
207
208 @mock.patch('plainbox.impl.session.resume.SessionPeekHelper3')
209 def test_peek_dispatch_v3(self, mocked_helper3):
210 data = gzip.compress(
211 b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
212 b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
213 b'},"results":{}},"version":3}')
214 SessionPeekHelper().peek(data)
215 mocked_helper3.resume_json.assertCalledOnce()
216
217 @mock.patch('plainbox.impl.session.resume.SessionPeekHelper4')
218 def test_peek_dispatch_v4(self, mocked_helper4):
219 data = gzip.compress(
220 b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
221 b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
222 b'},"results":{}},"version":4}')
223 SessionPeekHelper().peek(data)
224 mocked_helper4.resume_json.assertCalledOnce()
225
226 @mock.patch('plainbox.impl.session.resume.SessionPeekHelper5')
227 def test_peek_dispatch_v5(self, mocked_helper5):
228 data = gzip.compress(
229 b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
230 b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
231 b'},"results":{}},"version":5}')
232 SessionPeekHelper().peek(data)
233 mocked_helper5.resume_json.assertCalledOnce()
234
235 @mock.patch('plainbox.impl.session.resume.SessionPeekHelper6')
236 def test_peek_dispatch_v6(self, mocked_helper6):
237 data = gzip.compress(
238 b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
239 b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
240 b'},"results":{}},"version":6}')
241 SessionPeekHelper().peek(data)
242 mocked_helper6.resume_json.assertCalledOnce()
243
187class SessionResumeTests(TestCase):244class SessionResumeTests(TestCase):
188245
189 """246 """

Subscribers

People subscribed via source and target branches