Merge lp:~kissiel/checkbox/mandatory-jobs into lp:checkbox

Proposed by Maciej Kisielewski
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3959
Merged at revision: 3959
Proposed branch: lp:~kissiel/checkbox/mandatory-jobs
Merge into: lp:checkbox
Diff against target: 74 lines (+57/-0)
1 file modified
plainbox/plainbox/impl/session/test_resume.py (+57/-0)
To merge this branch: bzr merge lp:~kissiel/checkbox/mandatory-jobs
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+269011@code.launchpad.net

Description of the change

This MR adds the missing tests for SessionPeekHelpers.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plainbox/plainbox/impl/session/test_resume.py'
2--- plainbox/plainbox/impl/session/test_resume.py 2015-08-20 11:17:46 +0000
3+++ plainbox/plainbox/impl/session/test_resume.py 2015-08-25 08:17:34 +0000
4@@ -42,6 +42,7 @@
5 from plainbox.impl.session.resume import IncompatibleJobError
6 from plainbox.impl.session.resume import IncompatibleSessionError
7 from plainbox.impl.session.resume import ResumeDiscardQualifier
8+from plainbox.impl.session.resume import SessionPeekHelper
9 from plainbox.impl.session.resume import SessionResumeError
10 from plainbox.impl.session.resume import SessionResumeHelper
11 from plainbox.impl.session.resume import SessionResumeHelper1
12@@ -184,6 +185,62 @@
13 self.assertEqual(str(boom.exception), "Unsupported version 7")
14
15
16+class SessionPeekHelperTests(TestCase):
17+
18+ @mock.patch('plainbox.impl.session.resume.SessionPeekHelper1')
19+ def test_peek_dispatch_v1(self, mocked_helper1):
20+ data = gzip.compress(
21+ b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
22+ b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
23+ b'},"results":{}},"version":1}')
24+ SessionPeekHelper().peek(data)
25+ mocked_helper1.resume_json.assertCalledOnce()
26+
27+ @mock.patch('plainbox.impl.session.resume.SessionPeekHelper2')
28+ def test_peek_dispatch_v2(self, mocked_helper2):
29+ data = gzip.compress(
30+ b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
31+ b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
32+ b'},"results":{}},"version":2}')
33+ SessionPeekHelper().peek(data)
34+ mocked_helper2.resume_json.assertCalledOnce()
35+
36+ @mock.patch('plainbox.impl.session.resume.SessionPeekHelper3')
37+ def test_peek_dispatch_v3(self, mocked_helper3):
38+ data = gzip.compress(
39+ b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
40+ b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
41+ b'},"results":{}},"version":3}')
42+ SessionPeekHelper().peek(data)
43+ mocked_helper3.resume_json.assertCalledOnce()
44+
45+ @mock.patch('plainbox.impl.session.resume.SessionPeekHelper4')
46+ def test_peek_dispatch_v4(self, mocked_helper4):
47+ data = gzip.compress(
48+ b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
49+ b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
50+ b'},"results":{}},"version":4}')
51+ SessionPeekHelper().peek(data)
52+ mocked_helper4.resume_json.assertCalledOnce()
53+
54+ @mock.patch('plainbox.impl.session.resume.SessionPeekHelper5')
55+ def test_peek_dispatch_v5(self, mocked_helper5):
56+ data = gzip.compress(
57+ b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
58+ b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
59+ b'},"results":{}},"version":5}')
60+ SessionPeekHelper().peek(data)
61+ mocked_helper5.resume_json.assertCalledOnce()
62+
63+ @mock.patch('plainbox.impl.session.resume.SessionPeekHelper6')
64+ def test_peek_dispatch_v6(self, mocked_helper6):
65+ data = gzip.compress(
66+ b'{"session":{"desired_job_list":[],"jobs":{},"metadata":'
67+ b'{"app_blob":null,"flags":[],"running_job_name":null,"title":null'
68+ b'},"results":{}},"version":6}')
69+ SessionPeekHelper().peek(data)
70+ mocked_helper6.resume_json.assertCalledOnce()
71+
72 class SessionResumeTests(TestCase):
73
74 """

Subscribers

People subscribed via source and target branches