Code review comment for lp:~kissiel/checkbox/loc-svc-test-cc

Tested on an Arale device with OTA 10.1.

75 tests were run and passed:

uls/boost_ptree_settings_test_BoostPtreeSettings.correctly_reads_and_writes_values_to_file
uls/boost_ptree_settings_test_BoostPtreeSettings.does_not_throw_for_file_that_cannot_be_read_from
uls/boost_ptree_settings_test_BoostPtreeSettings.never_throws_on_syncing
uls/boost_ptree_settings_test_BoostPtreeSettings.throws_correct_exception_for_missing_value
uls/boost_ptree_settings_test_BoostPtreeSettings.values_are_correctly_stored
uls/connectivity_manager_test_ConnectivityManager.DISABLED_correctly_handles_wifi_devices_and_aps_on_init
uls/connectivity_manager_test_ConnectivityManager.DISABLED_queries_devices_and_modems_when_initialized
uls/connectivity_manager_test_ConnectivityManagerOnDevice.default_implementation_is_queryable_for_wifi_and_wwan_status_requires_hardware
uls/connectivity_manager_test_ConnectivityManagerOnDevice.default_implementation_is_queryable_for_wifis_and_radio_cells_requires_hardware
uls/connectivity_manager_test_ConnectivityManagerOnDevice.repeatedly_querying_the_connected_cell_works_requires_hardware
uls/connectivity_manager_test_ConnectivityManagerOnDevice.repeatedly_requesting_network_scans_works_requires_hardware
uls/controller_test_Controller.controller_starts_and_stops_updates_on_provider
uls/controller_test_Controller.controller_starts_and_stops_updates_on_provider_only_once_requires_hardware
uls/criteria_test_Criteria.AddedUpCriteriaSatisfiesAllIndividualCriteria
uls/criteria_test_Criteria.SatisfiesReturnsFalseForNonSatisfyingCriteria
uls/default_permission_manager_test_DefaultPermissionManager.for_now_only_local_sessions_are_accepted
uls/demultiplexing_reporter_test_DemultiplexingReporter.dispatches_calls_to_all_reporters
uls/engine_test_Engine.adding_a_null_provider_throws
uls/engine_test_Engine.adding_a_provider_creates_connections_to_engine_configuration_properties
uls/engine_test_Engine.adding_and_removing_providers_inserts_and_erases_from_underlying_collection
uls/engine_test_Engine.provider_selection_policy_is_invoked_when_matching_providers_to_criteria
uls/engine_test_Engine.reads_state_from_settings_on_construction
uls/engine_test_Engine.stores_state_from_settings_on_destruction
uls/gps_provider_test_AndroidGpsXtraDownloader.reading_configuration_from_valid_conf_file_works
uls/gps_provider_test_GpsProvider.DISABLED_accessing_starting_and_stopping_gps_provider_works_requires_hardware
uls/gps_provider_test_GpsProvider.injecting_a_reference_position_calls_into_the_hal
uls/gps_provider_test_GpsProvider.starting_updates_on_a_provider_instance_calls_into_the_hal
uls/gps_provider_test_GpsProvider.updates_from_hal_are_passed_on_by_the_provider
uls/gps_provider_test_GpsXtraDownloader.download_attempt_throws_if_timeout_is_reached
uls/gps_provider_test_GpsXtraDownloader.downloading_xtra_data_from_known_host_works
uls/gps_provider_test_GpsXtraDownloader.throws_for_missing_xtra_hosts
uls/gps_provider_test_GpsXtraDownloader.throws_for_unreachable_host
uls/gps_provider_test_HardwareAbstractionLayerFixture.DISABLED_provider_construction_works_requires_hardware
uls/harvester_test_Harvester.calls_start_and_stop_on_reporter
uls/harvester_test_Harvester.invokes_reporter_on_location_update_only_if_started
uls/harvester_test_Harvester.queries_wifis_and_cells_on_location_update
uls/ichnaea_reporter_test_IchnaeaReporter.issues_correct_posts_requests
uls/position_test_Position.AllFieldsAreInvalidForDefaultConstructor
uls/position_test_Position.EncodingAndDecodingGivesSameResults
uls/position_test_Position.InitWithLatLonAltGivesValidFieldsForLatLonAlt
uls/position_test_Position.InitWithLatLonGivesValidFieldsForLatLon
uls/provider_factory_test_ProviderFactory.adding_a_factory_works
uls/provider_factory_test_ProviderFactory.attempt_to_create_for_unknown_name_returns_null_ptr
uls/provider_factory_test_ProviderFactory.creating_for_known_name_invokes_factory_function
uls/provider_selection_policy_test_DefaultProviderSelectionPolicy.an_already_running_provider_is_preferred
uls/provider_selection_policy_test_DefaultProviderSelectionPolicy.if_no_provider_matches_criteria_null_is_returned
uls/provider_selection_policy_test_NonSelectingProviderSelectionPolicy.returns_a_selection_of_providers_that_dispatches_to_all_underlying_providers
uls/provider_selection_policy_test_ProviderSelection.feature_flags_calculation_works_correctly
uls/provider_test_Provider.delivering_a_message_invokes_subscribers
uls/provider_test_Provider.disabling_a_provider_stops_all_updates
uls/provider_test_Provider.feature_flags_passed_at_construction_are_correctly_stored
Note: Google Test filter = Provider.feature_flags_passed_at_construction_are_correctly_stored
uls/provider_test_Provider.requirement_flags_passed_at_construction_are_correctly_stored
uls/provider_test_Provider.starting_and_stopping_multiple_times_results_in_exactly_one_call_to_start_and_stop_on_provider
uls/provider_test_Provider.starting_updates_on_a_disabled_provider_does_nothing
uls/provider_test_ProxyProvider.start_and_stop_of_updates_propagates_to_correct_providers
uls/provider_test_ProxyProvider.update_signals_are_routed_from_correct_providers
uls/remote_provider_test_RemoteProvider.DISABLED_updates_are_fwd
uls/time_based_update_policy_test_TimeBasedUpdatePolicy.policy_ignores_inaccurate_updates
uls/time_based_update_policy_test_TimeBasedUpdatePolicy.policy_ignores_updates_that_are_too_old
uls/time_based_update_policy_test_TimeBasedUpdatePolicy.policy_uses_very_recent_updates
uls/trust_store_permission_manager_test_AppArmorProfileResolver.DISABLED_libapparmor_profile_resolver_returns_correct_profile_for_confined_process
uls/trust_store_permission_manager_test_AppArmorProfileResolver.libapparmor_profile_resolver_throws_for_apparmor_error
uls/trust_store_permission_manager_test_TrustStorePermissionManager.calls_out_to_agent
uls/trust_store_permission_manager_test_TrustStorePermissionManager.resolves_app_id
uls/trust_store_permission_manager_test_TrustStorePermissionManager.returns_rejected_for_throwing_agent
uls/trust_store_permission_manager_test_TrustStorePermissionManager.returns_rejected_for_throwing_app_id_resolver
uls/wgs84_test_Altitude.an_altitude_contains_value_passed_at_construction
uls/wgs84_test_HaversineDistance.calculating_the_haverstine_distance_yields_correct_values
uls/wgs84_test_Latitude.a_latitude_contains_value_passed_at_construction
uls/wgs84_test_Latitude.constructing_a_latitude_with_a_valid_value_does_not_throw
uls/wgs84_test_Latitude.constructing_a_latitude_with_invalid_value_throws
uls/wgs84_test_Longitude.a_longitude_contains_value_passed_at_construction
uls/wgs84_test_Longitude.constructing_a_longitude_with_a_valid_value_does_not_throw
uls/wgs84_test_Longitude.constructing_a_longitude_with_invalid_value_throws

In the report, some of them are marked as DISABLED, for instance "uls/connectivity_manager_test_ConnectivityManager.DISABLED_correctly_handles_wifi_devices_and_aps_on_init" which has the following output:

--------------------------------------
Running main() from gtest_main.cc
Note: Google Test filter = ConnectivityManager.DISABLED_correctly_handles_wifi_devices_and_aps_on_init
[==========] Running 0 tests from 0 test cases.
[==========] 0 tests from 0 test cases ran. (0 ms total)
[ PASSED ] 0 tests.

  YOU HAVE 1 DISABLED TEST
--------------------------------------

I suppose it's OK.