Merge lp:~kissiel/checkbox/fix-1476237-python-in-testing-shell into lp:checkbox

[Maciej Kisielewski]

This MR brings reference to Python qml object to all Qml testing shells. (the entities reposnible for running qml jobs)

29cfeec plainbox:qml_shell: add python to the stand-alone qml shell
6e1b403 plainbox:qml_shell: add python obj. to API of stand-alone shell
6085b9e plainbox:qml_shell: add python obj. to plainbox' qml shell
cd5aec5 checkbox-touch: add python obj. to qml shells in checkbox-touch

[Zygmunt Krynicki (zyga)]

Can you expand on how you intend to use this object. I have some ideas but I'd like to know what yours are.

review: Needs Information

[Sylvain Pineau (sylvain-pineau)]

Exactly what we need, thanks. +1

review: Approve

[Maciej Kisielewski (kissiel)]

> Can you expand on how you intend to use this object. I have some ideas but I'd
> like to know what yours are.

It's really up to testers' will, I didn't want to introduce any limitations. For many tests this should boild down to:

testingShell.python.imporModule('$test_logic')
var val = testingShell.python.eval('test_logic.foo()')

as this is the simplest way.

=== modified file 'checkbox-touch/components/QmlConfinedPage.qml'
--- checkbox-touch/components/QmlConfinedPage.qml	2015-09-15 11:07:31 +0000
+++ checkbox-touch/components/QmlConfinedPage.qml	2015-11-17 14:40:09 +0000
@@ -46,6 +46,7 @@
         property string name: "Checkbox-touch qml confined shell"
         property alias pageStack: qmlNativePage.pageStack
         property string sessionDir: app.sessionDir
+        property var python: app.py
         function getTest() {
             return test;
         }
 
=== modified file 'checkbox-touch/components/QmlNativePage.qml'
--- checkbox-touch/components/QmlNativePage.qml	2015-09-15 11:07:44 +0000
+++ checkbox-touch/components/QmlNativePage.qml	2015-11-17 14:40:09 +0000
@@ -42,6 +42,7 @@
         property string name: "Checkbox-touch qml shell"
         property alias pageStack: qmlNativePage.pageStack
         property string sessionDir: app.sessionDir
+        property var python: app.py
         function getTest() {
             return test;
         }
 
=== modified file 'checkbox-touch/confinement/plainbox-confined-shell.qml'
--- checkbox-touch/confinement/plainbox-confined-shell.qml	2015-10-07 17:04:55 +0000
+++ checkbox-touch/confinement/plainbox-confined-shell.qml	2015-11-17 14:40:09 +0000
@@ -33,7 +33,8 @@
     // information and functionality passed to qml job component
     property var testingShell: {
         "name": "Checkbox-touch qml confined shell",
-        "pageStack": pageStack
+        "pageStack": pageStack,
+        "python": py
     }
     property var activeTransfer;
 
 
=== modified file 'plainbox/plainbox/data/qml-shell/plainbox_qml_shell.qml'
--- plainbox/plainbox/data/qml-shell/plainbox_qml_shell.qml	2015-03-10 09:24:08 +0000
+++ plainbox/plainbox/data/qml-shell/plainbox_qml_shell.qml	2015-11-17 14:40:09 +0000
@@ -72,7 +72,8 @@
     // information and functionality passed to qml job component
     property var testingShell: {
         "name": "Plainbox qml shell",
-        "pageStack": pageStack
+        "pageStack": pageStack,
+        "python": py
     }
 
     Arguments {
 
=== modified file 'plainbox/plainbox/qml_shell/qml_shell.qml'
--- plainbox/plainbox/qml_shell/qml_shell.qml	2015-03-13 14:21:45 +0000
+++ plainbox/plainbox/qml_shell/qml_shell.qml	2015-11-17 14:40:09 +0000
@@ -33,6 +33,7 @@
 */
 import QtQuick 2.0
 import Ubuntu.Components 1.1
+import io.thp.pyotherside 1.4
 
 MainView {
     id: mainView
@@ -42,7 +43,8 @@
     // information and functionality passed to qml job component
     property var testingShell: {
         "name": "Standalone testing shell",
-        "pageStack": pageStack
+        "pageStack": pageStack,
+        "python": py
     }
 
     Arguments {
@@ -54,6 +56,9 @@
             valueNames: ["PATH"]
         }
     }
+    Python {
+        id: py
+    }
 
     Loader {
         id: loader