Code review comment for lp:~kissiel/checkbox/embedded-providers

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Hi (sigh, lost comments)

Please convert this to a PlugIn and use FsPlugInCollection instead. We have lots of goodies there and I'd like to make sure all things like that are handled via the plugin system.

The FileSystemPlugInCollection can be used as-is, just pass the correct filters to find manage.py and disable recursion. You will want to write a PlugIn subclass that knows how to load the thing from disk though.

Otherwise ok

review: Needs Fixing

« Back to merge proposal