Code review comment for lp:~kissiel/checkbox/converged-keyboard-support

Revision history for this message
Pierre Equoy (pieq) wrote :

The search filter is very handy, thanks!

Regarding the shortcuts, given there is no visual clues, it's a bit weird to have one (alt+C) that is "continue" in some screens and "comment" in others.

I'm not sure I understood how to use "alt+T". It unselects the test that is highlighted, but since there is no way to move the selection using the keyboard in the first place, its usefulness is limited (unless I missed something).

for the in test screens, I would suggest to use something similar to the cli:

    - alt + T ("Test") to start the test
    - alt + P ("Passed") to pass the test
    - alt + F ("Failed") to fail the test
    - alt + S ("Skipped") to skip the test
    - alt + C ("Comment") to comment the test

for selection screens:
    * alt + c - same as hitting continue (if anything is selected)
    * alt + t - toggle selection (same as the header action)

'in test' screens:
    * alt + t - to start the test (if in intro) or continue (if outcome is automatically resolved)
    * alt + y - to pass the test
    * alt + n - to fail the test
    * alt + x - to skip the test
    * alt + c - to enter comment

« Back to merge proposal