Ubuntu Terminal App

Code review comment for lp:~kill-animals/ubuntu-terminal-app/1349749workaround-select-font-added-to-preferences

  1. 1349749workaround-select-font-added-to-preferences
  2. Merge into trunk
Revision history for this message
Kill Animals (kill-animals) wrote :

So you made me question myself, and so I downloaded the branch, took out the font.family and removed

                        font.family: kterm.setVTFont(jsConf.getFontStyle(), kterm.font.pointSize);
                        font.pointSize: jsConf.getFontSize() //units.gu(1.5)

To no consequence that I could see. Everything still worked fine; even after starting and stopping the app. Perhaps this is only important if you have nothing to start with. I don't know how to test this though.

Perhaps though these should just be removed if they arent doing anything.

« Back to merge proposal