Code review comment for lp:~kill-animals/ubuntu-terminal-app/1349749workaround-select-font-added-to-preferences

Revision history for this message
Kill Animals (kill-animals) wrote :

> I believe that it works anyway because setVTFont is declared as a public
slot and not a public method. (some reminiscences in by brain).

Good golly! I wish someone told me it was that easy... Bloody macros uglying up my code

> That's true but as a side effect. Writing "font.family: kterm.setVTFont()",
is read as: set to font.family what is returned by the function
kterm.setVTFont().

Oh yah thats true; I am not setting a property; I am sending a signal. Good point; I'll move it on over to onCompleted.

> What's wrong with "font.family: jsConf.getFontStyle()" ?

Doesn't work ; its the same as "font.family: "Ubuntu Mono"" which also was not working...

« Back to merge proposal