Code review comment for lp:~kill-animals/ubuntu-terminal-app/1349749workaround-select-font-added-to-preferences

Revision history for this message
Kill Animals (kill-animals) wrote :

> you are doing it is calling the invokable function

This is what I don't get though, and trust me; I WAS CONFUSED
There is no Q_INVOKABLE for setVTFont's class.
It's invoked... SOMEHOW! but for the life of me I could not figure out where or how it was done.

The Q_INVOKABLE macro only appears in two places:
http://i.imgur.com/QAVVlDo.jpg

Also (I Think)
font.family: kterm.setVTFont(jsConf.getFontStyle(), kterm.font.pointSize);
Is initiated in the constructor; changing it on the fly if I recall, does not work; you require some signal handles which are in the configs scope.

To everything else; sounds fine though.

T

« Back to merge proposal