GTG

Code review comment for lp:~kiddo/gtg/pretty-delete-confirmation

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

Thanks for your patch! I have 2 small remarks:

1 - in browser.py, around line 1364, could you rename variable self.tasks_to_delete as self.del_tasks_cnt (or similar), just to make clear that it is not a list of tasks but an integer. It looks a bit confusing.

2 - could update CHANGELOG and AUTHORS by mentioning your changes and listing you as a contributor for the current version?

Thanks!

review: Needs Fixing

« Back to merge proposal