Code review comment for lp:~khussein/swift/authn

Revision history for this message
gholt (gholt) wrote :

You need to put a note in the description indicating how one should convert their SAIO over to use this branch.

I did the best I could based on the diff (changed my proxy-server.conf to have the three!? new auth middlewares) and not a single functional test passed.

Also, st did not work with this scheme.

You would need to update the SAIO docs and the How-To Install Multinode docs and probably other docs I'm not thinking of.

You changed a copyright notice that you probably didn't intend to.

I'll reiterate: It is best if you don't change the existing auth code and instead add a new one. Once the new one appears to work flawlessly and is a drop-in replacement for the old, then we can talk about defaults, etc.

review: Disapprove

« Back to merge proposal