1. There is one unit test failure
2. There are 9 functional test failures
3. There are no unit tests for the new pieces of middleware
4. There are no docs that explain how/when to use the different pieces of middleware
5. Do the saio or multiserver install docs need to change?
6. auth1 is a poor choice for the module name and class name
7. Is anything going to need to change when we move to swauth?
8. PEP8:
cthier@storage1:~/swift/authn$ pep8 -r swift/common/middleware/papiauth.py
swift/common/middleware/papiauth.py:43:50: W291 trailing whitespace
swift/common/middleware/papiauth.py:63:1: W391 blank line at end of file
cthier@storage1:~/swift/authn$ pep8 -r swift/common/middleware/auth.py
Initial comments:
1. There is one unit test failure
2. There are 9 functional test failures
3. There are no unit tests for the new pieces of middleware
4. There are no docs that explain how/when to use the different pieces of middleware
5. Do the saio or multiserver install docs need to change?
6. auth1 is a poor choice for the module name and class name
7. Is anything going to need to change when we move to swauth?
8. PEP8:
cthier@ storage1: ~/swift/ authn$ pep8 -r swift/common/ middleware/ auth1.py middleware/ auth1.py: 24:1: E302 expected 2 blank lines, found 1 middleware/ auth1.py: 97:1: W293 blank line contains whitespace middleware/ auth1.py: 112:75: W291 trailing whitespace middleware/ auth1.py: 113:76: W291 trailing whitespace middleware/ auth1.py: 140:1: E302 expected 2 blank lines, found 1
swift/common/
swift/common/
swift/common/
swift/common/
swift/common/
cthier@ storage1: ~/swift/ authn$ pep8 -r swift/common/ middleware/ papiauth. py middleware/ papiauth. py:43:50: W291 trailing whitespace middleware/ papiauth. py:63:1: W391 blank line at end of file storage1: ~/swift/ authn$ pep8 -r swift/common/ middleware/ auth.py
swift/common/
swift/common/
cthier@
cthier@ storage1: ~/swift/ authn$ pep8 -r swift/common/ middleware/ devauth. py middleware/ devauth. py:40:20: W291 trailing whitespace
swift/common/