Merge lp:~khurshid-alam/unity-settings-daemon/fix-airplane-switch into lp:unity-settings-daemon

Proposed by Khurshid Alam
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 4193
Merged at revision: 4193
Proposed branch: lp:~khurshid-alam/unity-settings-daemon/fix-airplane-switch
Merge into: lp:unity-settings-daemon
Diff against target: 64 lines (+47/-0)
2 files modified
gnome-settings-daemon/gnome-settings-bus.c (+46/-0)
gnome-settings-daemon/gnome-settings-bus.h (+1/-0)
To merge this branch: bzr merge lp:~khurshid-alam/unity-settings-daemon/fix-airplane-switch
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+368880@code.launchpad.net

Commit message

Fix airplane mode switch not appearing on network panel.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Indeed, from the build log 'warning: undefined reference to `gnome_settings_get_chassis_type' ... it's annoying that such problems don't fail the build :/

Thanks for the fix, it makes sense

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'gnome-settings-daemon/gnome-settings-bus.c'
--- gnome-settings-daemon/gnome-settings-bus.c 2016-05-20 17:01:02 +0000
+++ gnome-settings-daemon/gnome-settings-bus.c 2019-06-16 12:37:03 +0000
@@ -87,3 +87,49 @@
8787
88 return screen_saver_proxy;88 return screen_saver_proxy;
89}89}
90
91char *
92gnome_settings_get_chassis_type (void)
93{
94 char *ret = NULL;
95 GError *error = NULL;
96 GVariant *inner;
97 GVariant *variant = NULL;
98 GDBusConnection *connection;
99
100 connection = g_bus_get_sync (G_BUS_TYPE_SYSTEM,
101 NULL,
102 &error);
103 if (connection == NULL) {
104 g_warning ("system bus not available: %s", error->message);
105 g_error_free (error);
106 goto out;
107 }
108
109 variant = g_dbus_connection_call_sync (connection,
110 "org.freedesktop.hostname1",
111 "/org/freedesktop/hostname1",
112 "org.freedesktop.DBus.Properties",
113 "Get",
114 g_variant_new ("(ss)",
115 "org.freedesktop.hostname1",
116 "Chassis"),
117 NULL,
118 G_DBUS_CALL_FLAGS_NONE,
119 -1,
120 NULL,
121 &error);
122 if (variant == NULL) {
123 g_debug ("Failed to get property '%s': %s", "Chassis", error->message);
124 g_error_free (error);
125 goto out;
126 }
127
128 g_variant_get (variant, "(v)", &inner);
129 ret = g_variant_dup_string (inner, NULL);
130 g_variant_unref (inner);
131out:
132 g_clear_object (&connection);
133 g_clear_pointer (&variant, g_variant_unref);
134 return ret;
135}
90136
=== modified file 'gnome-settings-daemon/gnome-settings-bus.h'
--- gnome-settings-daemon/gnome-settings-bus.h 2016-05-20 17:01:02 +0000
+++ gnome-settings-daemon/gnome-settings-bus.h 2019-06-16 12:37:03 +0000
@@ -30,6 +30,7 @@
3030
31GsdSessionManager *gnome_settings_bus_get_session_proxy (void);31GsdSessionManager *gnome_settings_bus_get_session_proxy (void);
32GsdScreenSaver *gnome_settings_bus_get_screen_saver_proxy (void);32GsdScreenSaver *gnome_settings_bus_get_screen_saver_proxy (void);
33char * gnome_settings_get_chassis_type (void);
3334
34G_END_DECLS35G_END_DECLS
3536

Subscribers

People subscribed via source and target branches