Code review comment for ~khurshid-alam/ubuntu/+source/rhythmbox:master
Revision history for this message
| fossfreedom (fossfreedom) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I know I am not a reviewer ...
From a quick look it seems like a good conversion.
Given that no one uses this plugin other than Unity wouldn't this be a good opportunity to split the plugin into its own package? This would align more to the current Debian rhythmbox package that no longer ships zeitgeist and reduce the overhead of ubuntu specific patches.