Code review comment for lp:~khkim/epics-base/compression-3.15

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

Zeroing the buffer on reset seems sufficient.

As for epicsThreadValidateId(), it seems reasonable for the current implementation of epicsThreadResume(). IMO epicsThreadResume() is broken by design and should be removed, or epicsThread needs to be reimplemented around it. But this is the subject of another development.

Also, I'm commenting now because I've just noticed that there was activity on this branch. Since launchpad is sparing with email notifications it's a good idea to send a note to core-talk when pushing changes to a branch after a long period of inactivity.

review: Approve

« Back to merge proposal