Merge lp:~kgoetz/merge-o-matic/mom-misc into lp:merge-o-matic

Proposed by KarlGoetz
Status: Merged
Merge reported by: Loïc Minier
Merged at revision: not available
Proposed branch: lp:~kgoetz/merge-o-matic/mom-misc
Merge into: lp:merge-o-matic
Diff against target: 38 lines (+3/-3)
3 files modified
addcomment.py (+1/-1)
deb/version.py (+1/-1)
merge-status.py (+1/-1)
To merge this branch: bzr merge lp:~kgoetz/merge-o-matic/mom-misc
Reviewer Review Type Date Requested Status
Delyan Raychev (community) Approve
Ubuntu Core Development Team Pending
Review via email: mp+20202@code.launchpad.net
To post a comment you must log in.
Revision history for this message
KarlGoetz (kgoetz) wrote :

Just a few typos and a mode change on a file. I split them into a separate branch because I wasn't sure if they were correct.

lp:~kgoetz/merge-o-matic/mom-misc updated
174. By KarlGoetz

Missing space means 'the like' is printed as 'thelike'

Revision history for this message
Delyan Raychev (delqn) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 review approve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkuydVgACgkQ476ochDlJfTpTgCgn7Sr0suZ6/x/pvrSQD+Mww2e
5hMAoKg5CxJ7lnTpYm/9X9W0dpVTrXxM
=CmBC
-----END PGP SIGNATURE-----

review: Approve
Revision history for this message
Delyan Raychev (delqn) wrote :

Thank you Karl for the fixes!

review: Approve
Revision history for this message
Loïc Minier (lool) wrote :

I didn't merge the deb/version.py change since I do prefer the variable name in the docstring

Revision history for this message
KarlGoetz (kgoetz) wrote :

On Mon, 17 May 2010 12:52:25 -0000
Loïc Minier <email address hidden> wrote:

> I didn't merge the deb/version.py change since I do prefer the
> variable name in the docstring

no probs, thanks for the merge.
kk

--
Karl Goetz, (Kamping_Kaiser / VK5FOSS)
Debian contributor / gNewSense Maintainer
http://www.kgoetz.id.au
No, I won't join your social networking group

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addcomment.py'
--- addcomment.py 2009-03-13 12:49:35 +0000
+++ addcomment.py 2010-03-03 07:35:29 +0000
@@ -9,5 +9,5 @@
9 else:9 else:
10 req.write("Comment added.")10 req.write("Comment added.")
11else:11else:
12 req.write("I need at least two parameters: package and comment. component is optional.")12 req.write("I need at least two parameters: package and comment. Component is optional.")
13%>13%>
1414
=== modified file 'deb/version.py'
--- deb/version.py 2008-01-10 13:19:44 +0000
+++ deb/version.py 2010-03-03 07:35:29 +0000
@@ -127,7 +127,7 @@
127127
128128
129def strcut(str, idx, accept):129def strcut(str, idx, accept):
130 """Cut characters from str that are entirely in accept."""130 """Cut characters from string that are entirely in accept."""
131 ret = ""131 ret = ""
132 while idx < len(str) and str[idx] in accept:132 while idx < len(str) and str[idx] in accept:
133 ret += str[idx]133 ret += str[idx]
134134
=== modified file 'merge-status.py'
--- merge-status.py 2009-03-02 15:33:48 +0000
+++ merge-status.py 2010-03-03 07:35:29 +0000
@@ -224,7 +224,7 @@
224 "have your name and a list of the outstanding "224 "have your name and a list of the outstanding "
225 "Ubuntu changes.</li>")225 "Ubuntu changes.</li>")
226 print >>status, ("<li>Try and keep the diff small, this may involve "226 print >>status, ("<li>Try and keep the diff small, this may involve "
227 "manually tweaking <tt>po</tt> files and the"227 "manually tweaking <tt>po</tt> files and the "
228 "like.</li>")228 "like.</li>")
229 print >>status, "</ul>"229 print >>status, "</ul>"
230230
231231
=== modified file 'momlib.py' (properties changed: +x to -x)

Subscribers

People subscribed via source and target branches

to status/vote changes: