Code review comment for ~kevinbecker/+git/autotest-client-tests:kevinbecker/pmqtest

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Looking good.

One small nit is that we can check Max > 100 when parsing test output:

  for line in lines:
      if 'Max' in line:
          # Check if any max value is over 100
          if int(line.split()[-1]) > 100
              raise error.TestError('FAIL: Max latency over 100us.')

But this is rather trivial.

review: Approve

« Back to merge proposal