Code review comment for lp:~kevin-wright-1/u1db-qt/kevin-wright-1-addCreateIndexList

Revision history for this message
Cris Dywan (kalikiana) wrote :

We might want to replace the return values with setError() later. Also for consistency it'd be nice to use placeholders (:foo instead of ?) everywhere. For now, this looks great!

review: Approve

« Back to merge proposal