Code review comment for lp:~kevin-lacqui/ubuntu/oneiric/eggdrop/fix-for-885329

Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks a lot for identifying the problem and working on the fix!

A few things probably worth noting:
 - As per our SRU policy bugs in stable releases need to be fixed in the current development (precise) release first.
 - The eggdrop package uses the CDBS build- and patch-system, maybe it would make sense to borrow the relevant portion from http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635274 instead (and use the changelog entry, so whoever works on a merge next knows where the change came from.)
 - A minor nitpick: generally we try to wrap the changelog entries at 80 chars.

Apart from that: great work on identifying the problem and figuring out the fix!

review: Needs Fixing

« Back to merge proposal