Code review comment for lp:~kenneth-arnold/divisi/svdlibc-cleanup
Revision history for this message
| Ken Arnold (kenneth-arnold) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
This branch includes the offset SVD code, some cleanups and micro-optimizations to the SVDLIBC wrapper code, and some additional work on the tests. (It also adds a .unnormalized() method to LabeledView.)
I've tested it fairly extensively and regularly use it, but I'd like some review on it and independent testing before merging to trunk. My main concern is that I broke some edge case while cleaning up _svdlibc.pyx, but should also check that normal AnalogySpace and Blending still give correct results.